[Fix proposed] TabView bottom border line is too short

[eugenegff]

Describe the bug
TabView bottom border line is too short in new styles

Screenshots

[eugenegff]

Note, that in styles v1 shadow had Grid.ColumnSpan="4", covering LeftContentColumn, TabColumn, AddButtonColumn, RightContentColumn, but in Win11 like styles separator line covers only TabColumn and AddButtonColumn - seems to be simply overlooked

[beervoley]

@eugenegff I believe in this case it's caused by having custom content it TabView Footer.
If this is the case, it was done on purpose so users can customize that region without having to be locked in with the provided border. If you need to extend the border in this case, please use TabViewBorderBrush for the bottom border of the footer :)

[eugenegff]

@eugenegff I believe in this case it's caused by having custom content it TabView Footer.
If this is the case, it was done on purpose so users can customize that region without having to be locked in with the provided border. If you need to extend the border in this case, please use TabViewBorderBrush for the bottom border of the footer :)

That TabView is extended into TitleBar as in https://docs.microsoft.com/en-us/windows/apps/design/controls/tab-view sample, there are

                    <muxc:TabView.TabStripHeader>
                        <Grid x:Name="ShellTitlebarInset" Background="Transparent" />
                    </muxc:TabView.TabStripHeader>
                    <muxc:TabView.TabStripFooter>
                        <Grid x:Name="CustomDragRegion" Background="Transparent" />
                    </muxc:TabView.TabStripFooter>

If you insist that such non-intuitive and not backward compatible behavior is by design - then sample should probably be fixed.

Note, that XamlControlsGallery has many samples of TabView without TabStripFooter - all with this visual glitch. It actually forces us to always create TabStripFooter to fix it - and it is not good. OTOH, (rare?) applications that does not want this stroke at TabStripFooter can always hide it under opaque TabStripFooter or override TabViewBorderBrush

Here is screenshot of released app that uses WinUI 2.6 that shows that this visual glitch is regression - WinUI 2.6 has shadow at this place instead of the stroke line, and shadow extends on whole window width

[beervoley]

@eugenegff I believe in this case it's caused by having custom content it TabView Footer.
If this is the case, it was done on purpose so users can customize that region without having to be locked in with the provided border. If you need to extend the border in this case, please use TabViewBorderBrush for the bottom border of the footer :)

That TabView is extended into TitleBar as in https://docs.microsoft.com/en-us/windows/apps/design/controls/tab-view sample, there are

                    <muxc:TabView.TabStripHeader>
                        <Grid x:Name="ShellTitlebarInset" Background="Transparent" />
                    </muxc:TabView.TabStripHeader>
                    <muxc:TabView.TabStripFooter>
                        <Grid x:Name="CustomDragRegion" Background="Transparent" />
                    </muxc:TabView.TabStripFooter>

If you insist that such non-intuitive and not backward compatible behavior is by design - then sample should probably be fixed.

Note, that XamlControlsGallery has many samples of TabView without TabStripFooter - all with this visual glitch. It actually forces us to always create TabStripFooter to fix it - and it is not good. OTOH, (rare?) applications that does not want this stroke at TabStripFooter can always hide it under opaque TabStripFooter or override TabViewBorderBrush

Here is screenshot of released app that uses WinUI 2.6 that shows that this visual glitch is regression - WinUI 2.6 has shadow at this place instead of the stroke line, and shadow extends on whole window width

I see now. Yes, you're right - it's not very intuitive and it definitely should span the entire width. :)

[ghost]

🎉This issue was addressed in #5981, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220413001.:tada:

Handy links:

• Release Notes
• Official Nuget Release

[ghost]

🎉This issue was addressed in #5981, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220712001.:tada:

Handy links:

• Release Notes
• Official Nuget Release

[ghost]

🎉This issue was addressed in #5981, which has now been successfully released as Microsoft.UI.Xaml v2.8.0.:tada:

Handy links:

• Release Notes
• Official Nuget Release

[ghost]

🎉This issue was addressed in #5981, which has now been successfully released as Microsoft.UI.Xaml v2.8.2.:tada:

Handy links:

• Release Notes
• Official Nuget Release