Fixes TabView bottom border line is too short #5954

[eugenegff]

Fixes #5954

[beervoley]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[eugenegff]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 5981 in repo microsoft/microsoft-ui-xaml

[beervoley]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[beervoley]

@eugenegff could you please attach screenshots so we can verify the appearance?
With/without footer, with/without header :)

[eugenegff]

@eugenegff could you please attach screenshots so we can verify the appearance? With/without footer, with/without header :)

Before fix

After fix

After fix with header

[eugenegff]

Before fix with header and footer

[eugenegff]

Before fix without header and footer

[eugenegff]

I added TabViewHeader to one of test UI pages so that anybody could make such screenshots easily - third screenshot is with this modification.

[beervoley]

I added TabViewHeader to one of test UI pages so that anybody could make such screenshots easily - third screenshot is with this modification.

I believe that it will mess with a lot of tests that use that particular TabView for verification.

If you want to add an example, then it would be a good idea of adding another TabView :)

[eugenegff]

You right, I did not realize that this project was used for automated tests. Will force push only actual fix for the problem, removing modifications to test project

[beervoley]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[eugenegff]

##[error]The nuget command failed with exit code(1) and error(Failed to download package 'runtime.win10-x64-aot.runtime.native.System.IO.Compression.4.0.1' from 'https://pkgs.dev.azure.com/ms/66f07283-7714-4cbf-be8f-73dfb782cfdc/_packaging/1ea232aa-2b5d-4b2d-a163-a803b8f889db/nuget/v3/flat2/runtime.win10-x64-aot.runtime.native.system.io.compression/4.0.1/runtime.win10-x64-aot.runtime.native.system.io.compression.4.0.1.nupkg'.

[beervoley]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[beervoley]

I see this little issue:

the left arc is not full attached to the TabContainer as well as some part of the TabContainer border is visible where it shouldn't be. Is that some other changes you're playing with that are not in this PR?

[beervoley]

@eugenegff after #5994 and #5993 are checked in, please merge the updated main to fix the test issues we're running into.

[eugenegff]

@eugenegff after #5994 and #5993 are checked in, please merge the updated main to fix the test issues we're running into.

done

[eugenegff]

I see this little issue: the left arc is not full attached to the TabContainer as well as some part of the TabContainer border is visible where it shouldn't be. Is that some other changes you're playing with that are not in this PR?

It is separate, unrelated issue, stock TabView has it when scale is 150%, you can see it in XamlControlsGallery yourself.

I have fix for this issue too, but not sure, should I make separate PR or add it to the current one. Actually everything is so slow with contributions to MUX, so I don't want to slowdown this PR with additional fixes for much less important unrelated issue. With me being on the other side of the Earth, latency is 1 day for each our interaction.

[beervoley]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[beervoley]

I see this little issue: the left arc is not full attached to the TabContainer as well as some part of the TabContainer border is visible where it shouldn't be. Is that some other changes you're playing with that are not in this PR?

It is separate, unrelated issue, stock TabView has it when scale is 150%, you can see it in XamlControlsGallery yourself.

I have fix for this issue too, but not sure, should I make separate PR or add it to the current one. Actually everything is so slow with contributions to MUX, so I don't want to slowdown this PR with additional fixes for much less important unrelated issue. With me being on the other side of the Earth, latency is 1 day for each our interaction.

Please, submit it as a separate PR.

[eugenegff]

I see this little issue: the left arc is not full attached to the TabContainer as well as some part of the TabContainer border is visible where it shouldn't be. Is that some other changes you're playing with that are not in this PR?

It is separate, unrelated issue, stock TabView has it when scale is 150%, you can see it in XamlControlsGallery yourself.
I have fix for this issue too, but not sure, should I make separate PR or add it to the current one. Actually everything is so slow with contributions to MUX, so I don't want to slowdown this PR with additional fixes for much less important unrelated issue. With me being on the other side of the Earth, latency is 1 day for each our interaction.

Please, submit it as a separate PR.

Fix in separate PR #6001

[beervoley]

@eugenegff thanks for the fix!!
@ranjeshj checked in now

[ghost]

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220413001 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Official Nuget Release

[ghost]

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220712001 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Official Nuget Release

[ghost]

🎉Microsoft.UI.Xaml v2.8.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Official Nuget Release

[ghost]

🎉Microsoft.UI.Xaml v2.8.2 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Official Nuget Release