Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable allows_group_by_select_index #236

Merged
merged 4 commits into from
Mar 13, 2023
Merged

disable allows_group_by_select_index #236

merged 4 commits into from
Mar 13, 2023

Conversation

mShan0
Copy link
Contributor

@mShan0 mShan0 commented Mar 10, 2023

Fixes the following Django 4.2 tests:

aggregation.tests.AggregateTestCase.test_aggregation_default_not_in_aggregate,
aggregation.tests.AggregateTestCase.test_annotate_over_annotate,
aggregation.tests.AggregateTestCase.test_dates_with_aggregation,
aggregation.tests.AggregateTestCase.test_more_aggregation,

aggregation_regress.tests.AggregationTests.test_aggregate_and_annotate_duplicate_columns,
aggregation_regress.tests.AggregationTests.test_aggregate_and_annotate_duplicate_columns_proxy, 
aggregation_regress.tests.AggregationTests.test_aggregate_and_annotate_duplicate_columns_unmanaged,
aggregation_regress.tests.AggregationTests.test_aggregate_annotation,
aggregation_regress.tests.AggregationTests.test_aggregate_on_relation, 
aggregation_regress.tests.AggregationTests.test_annotate_on_relation,
aggregation_regress.tests.AggregationTests.test_annotation,
aggregation_regress.tests.AggregationTests.test_more_more, 
aggregation_regress.tests.AggregationTests.test_more_more_more,

db_functions.comparison.test_cast.CastTests.test_cast_from_db_datetime_to_date_group_by,

expressions_case.tests.CaseExpressionTests.test_aggregation_empty_cases,

queries.tests.ValuesQuerysetTests.test_named_values_list_with_fields,
queries.tests.ValuesQuerysetTests.test_named_values_list_without_fields,

model_fields.test_jsonfield.TestQuerying.test_order_grouping_custom_decoder,
model_fields.test_jsonfield.TestQuerying.test_ordering_grouping_by_key_transform

Also fixes these tests:

'aggregation.tests.AggregateTestCase.test_expression_on_aggregation',

'aggregation_regress.tests.AggregationTests.test_annotated_conditional_aggregate',

'annotations.tests.NonAggregateAnnotationTestCase.test_full_expression_annotation_with_aggregation',

'db_functions.comparison.test_cast.CastTests.test_cast_to_integer',

@mShan0 mShan0 merged commit 895909c into django42 Mar 13, 2023
@mShan0 mShan0 deleted the fix-aggregate-tests branch March 13, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant