Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable allows_group_by_select_index #236

Merged
merged 4 commits into from
Mar 13, 2023
Merged

disable allows_group_by_select_index #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6875151
disable allows_group_by_select_index
mShan0 Mar 10, 2023
9ac7c2f
unskip old tests
mShan0 Mar 10, 2023
9816cdf
unskip some tests
mShan0 Mar 13, 2023
8e5c9cd
skip more tests
mShan0 Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mssql/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@


class DatabaseFeatures(BaseDatabaseFeatures):
allows_group_by_select_index = False
allow_sliced_subqueries_with_in = False
can_introspect_autofield = True
can_introspect_json_field = False
Expand Down Expand Up @@ -71,4 +72,4 @@ def introspected_field_types(self):
return {
**super().introspected_field_types,
"DurationField": "BigIntegerField",
}
}
4 changes: 0 additions & 4 deletions testapp/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@

TEST_RUNNER = "testapp.runners.ExcludedTestSuiteRunner"
EXCLUDED_TESTS = [
'aggregation.tests.AggregateTestCase.test_expression_on_aggregation',
'aggregation_regress.tests.AggregationTests.test_annotated_conditional_aggregate',
'aggregation_regress.tests.AggregationTests.test_annotation_with_value',
'aggregation.tests.AggregateTestCase.test_distinct_on_aggregate',
'annotations.tests.NonAggregateAnnotationTestCase.test_annotate_exists',
Expand Down Expand Up @@ -173,9 +171,7 @@
'expressions.tests.FTimeDeltaTests.test_time_subquery_subtraction',
'migrations.test_operations.OperationTests.test_alter_field_reloads_state_on_fk_with_to_field_target_type_change',
'schema.tests.SchemaTests.test_alter_smallint_pk_to_smallautofield_pk',

'annotations.tests.NonAggregateAnnotationTestCase.test_combined_expression_annotation_with_aggregation',
'db_functions.comparison.test_cast.CastTests.test_cast_to_integer',
'db_functions.datetime.test_extract_trunc.DateFunctionTests.test_extract_func',
'db_functions.datetime.test_extract_trunc.DateFunctionTests.test_extract_iso_weekday_func',
'db_functions.datetime.test_extract_trunc.DateFunctionWithTimeZoneTests.test_extract_func',
Expand Down