This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
fix bug of advisor and assesor written backwards #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 6, 2020 10:07
|
I think the logic is kinda "too specific". |
liuzhe-lz
approved these changes
Nov 13, 2020
liuzhe-lz
reviewed
Nov 13, 2020
| @@ -32,8 +37,8 @@ export const Command1 = (): any => { | |||
| <div> | |||
| <p className='command'>Training platform</p> | |||
| <div className='nowrap'>{EXPERIMENT.profile.params.trainingServicePlatform}</div> | |||
| <p className='lineMargin'>{title}</p> | |||
| <div className='nowrap'>{builtinName}</div> | |||
| <p className='lineMargin'>{title.join('/')}</p> | |||
There was a problem hiding this comment.
seems like Tuner/Assessor/Advisor is better than Tuner / Assessor / Advisor, It's also similar with the website style. such as this button
ultmaster
approved these changes
Nov 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
advisor.builtinAdvisorNameis written on webui, but when user use other name instead of the fieldbuiltinAdvisorName, webui will miss this value