Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

fix bug of advisor and assesor written backwards #3070

Merged
merged 5 commits into from
Nov 16, 2020
Merged

fix bug of advisor and assesor written backwards #3070

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b047562
fix bug of advisor and assesor written backwards
Nov 6, 2020
0765749
add advisor.className choose
Nov 6, 2020
7025a72
update
Nov 6, 2020
851333c
fix comments of liuzhe
Nov 11, 2020
98f2ece
last commit is wrong, fix comments of liuzhe
Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions ts/webui/src/components/overview/command/Command1.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,24 +6,29 @@ export const Command1 = (): any => {
const tuner = EXPERIMENT.profile.params.tuner;
const advisor = EXPERIMENT.profile.params.advisor;
const assessor = EXPERIMENT.profile.params.assessor;
let title = '';
let builtinName = '';
const title: string[] = [];
const builtinName: string[] = [];
if (tuner !== undefined) {
title = title.concat('Tuner');
title.push('Tuner');
if (tuner.builtinTunerName !== undefined) {
builtinName = builtinName.concat(tuner.builtinTunerName);
builtinName.push(tuner.builtinTunerName);
}
}

if (advisor !== undefined) {
title = title.concat('/ Assessor');
title.push('Advisor');
if (advisor.builtinAdvisorName !== undefined) {
builtinName = builtinName.concat(advisor.builtinAdvisorName);
builtinName.push(advisor.builtinAdvisorName);
}
if (advisor.className !== undefined) {
builtinName.push(advisor.className);
}
}

if (assessor !== undefined) {
title = title.concat('/ Addvisor');
title.push('Assessor');
if (assessor.builtinAssessorName !== undefined) {
builtinName = builtinName.concat(assessor.builtinAssessorName);
builtinName.push(assessor.builtinAssessorName);
}
}

Expand All @@ -32,8 +37,8 @@ export const Command1 = (): any => {
<div>
<p className='command'>Training platform</p>
<div className='nowrap'>{EXPERIMENT.profile.params.trainingServicePlatform}</div>
<p className='lineMargin'>{title}</p>
<div className='nowrap'>{builtinName}</div>
<p className='lineMargin'>{title.join('/')}</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.join(' / ')

Copy link
Contributor Author

@Lijiaoa Lijiaoa Nov 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like Tuner/Assessor/Advisor is better than Tuner / Assessor / Advisor, It's also similar with the website style. such as this button
image

<div className='nowrap'>{builtinName.join('/')}</div>
</div>
</div>
);
Expand Down