Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Use elsa for debuggable_module::Loader #2703

Merged
merged 5 commits into from
Jan 17, 2023
Merged

Use elsa for debuggable_module::Loader #2703

merged 5 commits into from
Jan 17, 2023

Conversation

Porges
Copy link
Member

@Porges Porges commented Dec 14, 2022

elsa provides an nice interface for write-once collections, allowing borrows while writes occur.

@Porges Porges marked this pull request as ready for review December 14, 2022 21:02
@Porges Porges requested a review from ranweiler December 14, 2022 21:02
@Porges Porges changed the title Use elsa for debuggable_module::Loader Use elsa for debuggable_module::Loader Dec 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Merging #2703 (62c4194) into main (5bf0c21) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2703      +/-   ##
==========================================
+ Coverage   29.08%   29.09%   +0.01%     
==========================================
  Files         321      321              
  Lines       38454    38437      -17     
==========================================
  Hits        11185    11185              
+ Misses      27269    27252      -17     
Impacted Files Coverage Δ
src/agent/debuggable-module/src/loader.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Porges Porges force-pushed the use-elsa branch 2 times, most recently from 8cba884 to 98b558b Compare December 16, 2022 01:36
@Porges Porges enabled auto-merge (squash) December 16, 2022 01:36
@Porges Porges merged commit 7482700 into main Jan 17, 2023
chkeita pushed a commit to chkeita/onefuzz that referenced this pull request Jan 17, 2023
chkeita added a commit that referenced this pull request Jan 18, 2023
* Adding an analysis task to the libfuzzer template

* format

* build fix

* Use `elsa` for debuggable_module::loader (#2703)

* build fix

Co-authored-by: George Pollard <gpollard@microsoft.com>
@nharper285 nharper285 mentioned this pull request Jan 19, 2023
@Porges Porges deleted the use-elsa branch February 1, 2023 01:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants