This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix regression template file
…into regression-suggestions
chkeita
reviewed
Mar 11, 2021
chkeita
approved these changes
Mar 11, 2021
ranweiler
suggested changes
Mar 13, 2021
Co-authored-by: Joe Ranweiler <joe@lemma.co>
ranweiler
approved these changes
Mar 13, 2021
Co-authored-by: Joe Ranweiler <joe@lemma.co>
Co-authored-by: Cheick Keita <kcheick@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
regression
tasks to identify if new builds demonstrate or fix previously identified crashes.The intent is to support two models:
template
, to enable automatic updating of ADO Work items or GitHub issues. While the notification integration does not work yet, consider automatic marking bugs found via fuzzing as "no longer crashes" or re-opening bugs that were re-introduced.To demonstrate this idea, I added
libfuzzer-regression
test binaries ofbroken.exe
andfixed.exe
(not yet included in integration testing). As you would expect by the name,broken.exe
has a bug andfixed.exe
does not.We can demonstrate this by doing the following:
During the first job, we'll see a single unique crash report created and no regression reports.
During the second job, we'll still have that unique one crash report. In the job specific regression reports container, now we'll have a regression report. Upon pulling that regression report, we'll see that the
crash_test_result.no_repro
exists.During the third job, we'll still have that unique one crash report. In the job specific regression reports container, now we'll have a regression report. Upon pulling that regression report, we'll see that the
crash_test_result.crash_result
exists.Addresses #308.
Note, this is in large part built from the work of #433.