Migrate onnxrewriter #1346
Migrate onnxrewriter #1346
Conversation
Squashed of the following steps: - #1328 - #1329 - #1330 - #1331 - #1332 - #1333 - #1343 - #1345 Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Xavier Dupré <xadupre@users.noreply.github.com> Co-authored-by: "G. Ramalingam" <grama@microsoft.com> Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnavi@users.noreply.github.com> Co-authored-by: Ti-Tai Wang <titaiwang@microsoft.com> [ghstack-poisoned]
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Test Results 24 files ± 0 24 suites ±0 17m 48s ⏱️ - 1h 30m 16s Results for commit 667ab08. ± Comparison against base commit e29b43a. ♻️ This comment has been updated with latest results. |
titaiwangms
added
the
change base before merge
titaiwangms
removed
the
change base before merge
Squashed of the following steps: - #1328 - #1329 - #1330 - #1331 - #1332 - #1333 - #1343 - #1345 Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1users.noreply.github.com> Co-authored-by: Justin Chu <justinchubyusers.noreply.github.com> Co-authored-by: Xavier Dupré <xadupreusers.noreply.github.com> Co-authored-by: "G. Ramalingam" <gramamicrosoft.com> Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnaviusers.noreply.github.com> Co-authored-by: Ti-Tai Wang <titaiwangmicrosoft.com> [ghstack-poisoned]
| # for name, init in pattern.initializers.items(): | ||
| # # We add them to the graph, they will be removed if unused. | ||
| # new_name = g.make_initializer(name, init) | ||
| # replacements[new_name] = name |
Check notice
Code scanning / CodeQL
Commented-out code Note
| # def exit_scope(self, graph: onnx.GraphProto) -> SubScope: | ||
| # # Also sync updated ir values back to value_info in graph. | ||
| # sub_scope = super().exit_scope(graph) |
Check notice
Code scanning / CodeQL
Commented-out code Note
| This is a placeholder, subject to simplification when a proper IR is defined. | ||
| """ | ||
|
|
||
| def get_input(self, node: onnx.NodeProto, index: int) -> ir.Value | None: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
|
|
||
| def get_input(self, node: onnx.NodeProto, index: int) -> ir.Value | None: ... | ||
|
|
||
| def get_output(self, node: onnx.NodeProto, index: int) -> ir.Value | None: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
|
|
||
| def get_output(self, node: onnx.NodeProto, index: int) -> ir.Value | None: ... | ||
|
|
||
| def input_const_value(self, node: onnx.NodeProto, index: int) -> ir.ConcreteValue: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
|
|
||
| def lookup_version(self, domain: str) -> int: ... | ||
|
|
||
| def convert_attributes(self, attributes: Sequence[onnx.AttributeProto]) -> dict: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
|
|
||
| def convert_attributes(self, attributes: Sequence[onnx.AttributeProto]) -> dict: ... | ||
|
|
||
| def new_constant(self, name: str, value: Any) -> Sequence[onnx.NodeProto] | None: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class FunctionRewriteError(RuntimeError): ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| # The rule is easy to create. | ||
|
|
||
|
|
||
| rule = org.make_pattern_rule( |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning
|
|
||
| # Currently, the replacement graph function is the same as the pattern function. | ||
| # This may change in the future. | ||
| _handle_replacement_return_value = _handle_pattern_return_value |
Check notice
Code scanning / CodeQL
Unused global variable Note
Squashed of the following steps: - #1328 - #1329 - #1330 - #1331 - #1332 - #1333 - #1343 - #1345 Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1users.noreply.github.com> Co-authored-by: Justin Chu <justinchubyusers.noreply.github.com> Co-authored-by: Xavier Dupré <xadupreusers.noreply.github.com> Co-authored-by: "G. Ramalingam" <gramamicrosoft.com> Co-authored-by: kunal-vaishnavi <115581922+kunal-vaishnaviusers.noreply.github.com> Co-authored-by: Ti-Tai Wang <titaiwangmicrosoft.com> [ghstack-poisoned]
Stack from ghstack (oldest at bottom):
Squashed of the following steps:
_legacy_irfolder #1332Co-authored-by: Shubham Bhokare 32080845+shubhambhokare1@users.noreply.github.com
Co-authored-by: Justin Chu justinchuby@users.noreply.github.com
Co-authored-by: Xavier Dupré xadupre@users.noreply.github.com
Co-authored-by: "G. Ramalingam" grama@microsoft.com
Co-authored-by: kunal-vaishnavi 115581922+kunal-vaishnavi@users.noreply.github.com
Co-authored-by: Ti-Tai Wang titaiwang@microsoft.com