Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] Improve from_proto/to_proto typing with overloads #1992

Merged
merged 8 commits into from
Dec 31, 2024

Add type ignore comments for overload overlap

67a0002
Select commit
Loading
Failed to load commit list.
Merged

[IR] Improve from_proto/to_proto typing with overloads #1992

Add type ignore comments for overload overlap
67a0002
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Dec 31, 2024 in 0s

51.56% of diff hit (target 74.70%)

View this Pull Request on Codecov

51.56% of diff hit (target 74.70%)

Annotations

Check warning on line 175 in onnxscript/ir/serde.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/ir/serde.py#L175 

Added line #L175 was not covered by tests

Check warning on line 177 in onnxscript/ir/serde.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/ir/serde.py#L177 

Added line #L177 was not covered by tests

Check warning on line 181 in onnxscript/ir/serde.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/ir/serde.py#L181 

Added line #L181 was not covered by tests

Check warning on line 185 in onnxscript/ir/serde.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/ir/serde.py#L185 

Added line #L185 was not covered by tests

Check warning on line 732 in onnxscript/ir/serde.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/ir/serde.py#L732 

Added line #L732 was not covered by tests
View more details on Codecov