Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] Improve from_proto/to_proto typing with overloads #1992

Merged
merged 8 commits into from
Dec 31, 2024

Add type ignore comments for overload overlap

67a0002
Select commit
Loading
Failed to load commit list.
Merged

[IR] Improve from_proto/to_proto typing with overloads #1992

Add type ignore comments for overload overlap
67a0002
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 31, 2024 in 0s

67.57% (-7.13%) compared to 3c75013

View this Pull Request on Codecov

67.57% (-7.13%) compared to 3c75013

Details

Codecov Report

Attention: Patch coverage is 51.56250% with 31 lines in your changes missing coverage. Please review.

Project coverage is 67.57%. Comparing base (3c75013) to head (67a0002).

Files with missing lines Patch % Lines
onnxscript/ir/serde.py 51.56% 9 Missing and 22 partials ⚠️

❗ There is a different number of reports uploaded between BASE (3c75013) and HEAD (67a0002). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (3c75013) HEAD (67a0002)
24 8
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1992      +/-   ##
==========================================
- Coverage   74.70%   67.57%   -7.13%     
==========================================
  Files         273      273              
  Lines       29348    29399      +51     
  Branches     3368     3394      +26     
==========================================
- Hits        21923    19866    -2057     
- Misses       6385     8485    +2100     
- Partials     1040     1048       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.