Add Azure Functions for creating images and animations #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the "animation" and "image" functions, as well as the "funclib" library that contains reusable code for fetching rasters from the PC data API.
lossyrob
commented
Aug 5, 2022
lossyrob
commented
Aug 5, 2022
lossyrob
commented
Aug 5, 2022
lossyrob
commented
Aug 5, 2022
mmcfarland
approved these changes
Aug 9, 2022
pcfuncs/animation/constants.py
Outdated
| MAX_TILE_COUNT = 16 | ||
|
|
||
| MAX_FRAMES = 24 | ||
| MAX_CONCURRENCY = 10 |
There was a problem hiding this comment.
Looks like this is not overridable by the settings; fwiw, I currently have staging set to 15 and have dialed it up over twice that to get better performance. Do you think it's too disruptive to put a higher max?
There was a problem hiding this comment.
I'll make it part of the settings so that we can play around with it.
Edit: Perhaps it makes sense not to limit us for what we put in the settings, and have that be a default with no validation rule.
pcfuncs/animation/settings.py
Outdated
| def get(cls) -> "AnimationSettings": | ||
| import os | ||
|
|
||
| logger.info(f"DEBUG: {os.environ.get('ANIMATION_CONTAINER_ACCOUNT_KEY')}") |
There was a problem hiding this comment.
Prod looks to be set up to use a managed identity but consider dropping this to prevent accidental credential leaks.
There was a problem hiding this comment.
Good catch, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an Azure Functions app that provides Function endpoints that produce images and animated gifs from images produced through mosaicing tiles from the tile server.
This is based on the Azure Functions work in PlanetaryComputerDataCatalog. The animation endpoint is lightly refactored from that codebase, and the image endpoint is based on the techniques used there.
How Has This Been Tested?
Functions have been deployed to the staging environment manually. Tested through hitting the endpoints manually with Thunder Client, and through the development of https://github.com/microsoft/planetary-computer-teams-background