-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(roll): roll Playwright to 1.40.0-alpha-oct-18-2023 #2757
Conversation
65ee68b
to
88a0285
Compare
88a0285
to
e1e982d
Compare
@@ -2,7 +2,7 @@ | |||
<PropertyGroup> | |||
<AssemblyVersion>1.39.0</AssemblyVersion> | |||
<PackageVersion>$(AssemblyVersion)</PackageVersion> | |||
<DriverVersion>1.39.0</DriverVersion> | |||
<DriverVersion>1.40.0-alpha-oct-18-2023</DriverVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we roll to 1.40.0 right away?
src/Playwright/Core/Waiter.cs
Outdated
internal void RejectOnEvent<T>( | ||
object eventSource, | ||
string e, | ||
Func<PlaywrightException> navigationExceptionPredicate, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can we pass navigationException
directly instead of a function? Also predicate sounds like a wrong term for this parameter.
#2690