chore(roll): roll Playwright to 1.40.0-alpha-oct-18-2023

README.md

@@ -3,8 +3,8 @@
 
 |          | Linux | macOS | Windows |
 |   :---   | :---: | :---: | :---:   |
-| Chromium <!-- GEN:chromium-version -->119.0.6045.9<!-- GEN:stop --> | ✅ | ✅ | ✅ |
-| WebKit <!-- GEN:webkit-version -->17.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
+| Chromium <!-- GEN:chromium-version -->119.0.6045.21<!-- GEN:stop --> | ✅ | ✅ | ✅ |
+| WebKit <!-- GEN:webkit-version -->17.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 | Firefox <!-- GEN:firefox-version -->118.0.1<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 
 Playwright for .NET is the official language port of [Playwright](https://playwright.dev), the library to automate [Chromium](https://www.chromium.org/Home), [Firefox](https://www.mozilla.org/en-US/firefox/new/) and [WebKit](https://webkit.org/) with a single API. Playwright is built to enable cross-browser web automation that is **ever-green**, **capable**, **reliable** and **fast**.

src/Common/Version.props

@@ -2,7 +2,7 @@
   <PropertyGroup>
     <AssemblyVersion>1.39.0</AssemblyVersion>
     <PackageVersion>$(AssemblyVersion)</PackageVersion>
-    <DriverVersion>1.39.0</DriverVersion>
+    <DriverVersion>1.40.0-alpha-oct-18-2023</DriverVersion>
     <ReleaseVersion>$(AssemblyVersion)</ReleaseVersion>
     <FileVersion>$(AssemblyVersion)</FileVersion>
     <NoDefaultExcludes>true</NoDefaultExcludes>

src/Playwright.Tests/BrowserContextBasicTests.cs

@@ -189,7 +189,7 @@ public async Task CloseShouldAbortWaitForEvent()
         var waitTask = context.WaitForPageAsync();
         await context.CloseAsync();
         var exception = await PlaywrightAssert.ThrowsAsync<PlaywrightException>(() => waitTask);
-        Assert.AreEqual("Context closed", exception.Message);
+        Assert.AreEqual(TestConstants.TargetClosedErrorMessage, exception.Message);
     }
 
     [PlaywrightTest("browsercontext-basic.spec.ts", "should not report frameless pages on error")]

src/Playwright.Tests/BrowserTests.cs

@@ -32,13 +32,13 @@ public async Task ShouldCreateNewPage()
     {
         var browser = await Playwright[TestConstants.BrowserName].LaunchAsync();
         var page1 = await browser.NewPageAsync();
-        Assert.That(browser.Contexts, Has.Length.EqualTo(1));
+        Assert.AreEqual(1, browser.Contexts.Count);
 
         var page2 = await browser.NewPageAsync();
         Assert.AreEqual(2, browser.Contexts.Count);
 
         await page1.CloseAsync();
-        Assert.That(browser.Contexts, Has.Length.EqualTo(1));
+        Assert.AreEqual(1, browser.Contexts.Count);
 
         await page2.CloseAsync();
         await browser.CloseAsync();

src/Playwright.Tests/BrowserTypeConnectTests.cs

@@ -209,7 +209,7 @@ public async Task ShouldThrowWhenWhenCallingWaitForNavigationAfterDisconnect()
 
         Assert.AreEqual(browser.IsConnected, false);
         var exception = await PlaywrightAssert.ThrowsAsync<PlaywrightException>(async () => await page.WaitForNavigationAsync());
-        StringAssert.Contains("Navigation failed because page was closed", exception.Message);
+        StringAssert.Contains(TestConstants.TargetClosedErrorMessage, exception.Message);
     }
 
     [PlaywrightTest("browsertype-connect.spec.ts", "should reject navigation when browser closes")]
@@ -271,7 +271,7 @@ public async Task ShouldTerminateNetworkWaiters()
         async Task CheckTaskHasException(Task task)
         {
             var exception = await PlaywrightAssert.ThrowsAsync<PlaywrightException>(async () => await task);
-            StringAssert.Contains("Page closed", exception.Message);
+            StringAssert.Contains(TestConstants.TargetClosedErrorMessage, exception.Message);
             StringAssert.DoesNotContain("Timeout", exception.Message);
 
         }

src/Playwright.Tests/ElementHandleEvalOnSelectorTests.cs

@@ -81,6 +81,6 @@ public async Task ShouldThrowInCaseOfMissingSelector()
         await Page.SetContentAsync(htmlContent);
         var elementHandle = await Page.QuerySelectorAsync("#myId");
         var exception = await PlaywrightAssert.ThrowsAsync<PlaywrightException>(() => elementHandle.EvalOnSelectorAsync(".a", "node => node.innerText"));
-        StringAssert.Contains("failed to find element matching selector \".a\"", exception.Message);
+        StringAssert.Contains("Failed to find element matching selector \".a\"", exception.Message);
     }
 }

src/Playwright.Tests/EvalOnSelectorTests.cs

@@ -136,7 +136,7 @@ public async Task ShouldThrowErrorIfNoElementIsFound()
     {
         var exception = await PlaywrightAssert.ThrowsAsync<PlaywrightException>(()
             => Page.EvalOnSelectorAsync("section", "e => e.id"));
-        StringAssert.Contains("failed to find element matching selector \"section\"", exception.Message);
+        StringAssert.Contains("Failed to find element matching selector \"section\"", exception.Message);
     }
 
     [PlaywrightTest("eval-on-selector.spec.ts", "should support >> syntax")]

src/Playwright.Tests/PageBasicTests.cs

@@ -36,7 +36,7 @@ public async Task ShouldRejectAllPromisesWhenPageIsClosed()
             newPage.EvaluateAsync<string>("() => new Promise(r => { })"),
             newPage.CloseAsync()
         ));
-        StringAssert.Contains("Target closed", exception.Message);
+        StringAssert.Contains(TestConstants.TargetClosedErrorMessage, exception.Message);
     }
 
     [PlaywrightTest("page-basic.spec.ts", "async stacks should work")]
@@ -147,7 +147,7 @@ public async Task ShouldFailWithErrorUponDisconnect()
         var task = Page.WaitForDownloadAsync();
         await Page.CloseAsync();
         var exception = await PlaywrightAssert.ThrowsAsync<PlaywrightException>(() => task);
-        StringAssert.Contains("Page closed", exception.Message);
+        StringAssert.Contains(TestConstants.TargetClosedErrorMessage, exception.Message);
     }
 
     [PlaywrightTest("page-basic.spec.ts", "should have sane user agent")]
@@ -245,7 +245,7 @@ public async Task ShouldTerminateNetworkWaiters()
         for (int i = 0; i < 2; i++)
         {
             string message = exception.Message;
-            StringAssert.Contains("Page closed", message);
+            StringAssert.Contains(TestConstants.TargetClosedErrorMessage, message);
             Assert.That(message, Does.Not.Contain("Timeout"));
         }
     }

src/Playwright.Tests/ScreencastTests.cs

@@ -217,7 +217,13 @@ public async Task VideoPathSaveAsDoesNotHangImmediatelyAfterLaunchPersistentCont
         catch (Exception)
         {
         }
-        await page.Video.DeleteAsync();
+        try
+        {
+            await page.Video.DeleteAsync();
+        }
+        catch (Exception)
+        {
+        }
     }
 
     [PlaywrightTest("screencast.spec.ts", "saveAs should throw when no video frames")]

src/Playwright.Tests/TestConstants.cs

@@ -44,4 +44,6 @@ internal static class TestConstants
     internal static readonly bool IsMacOSX = RuntimeInformation.IsOSPlatform(OSPlatform.OSX);
     internal static readonly bool IsWindows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
     internal static readonly bool IsLinux = RuntimeInformation.IsOSPlatform(OSPlatform.Linux);
+
+    internal static readonly string TargetClosedErrorMessage = "Target page, context or browser has been closed";
 }

src/Playwright.Tests/WorkersTests.cs

@@ -58,7 +58,7 @@ public async Task ShouldEmitCreatedAndDestroyedEvents()
         await Page.EvaluateAsync("workerObj => workerObj.terminate()", workerObj);
         Assert.AreEqual(worker, await workerDestroyedTcs.Task);
         var exception = await PlaywrightAssert.ThrowsAsync<PlaywrightException>(() => workerThisObj.GetPropertyAsync("self"));
-        StringAssert.IsMatch("(Worker was closed)|(Target closed)", exception.Message);
+        StringAssert.Contains(TestConstants.TargetClosedErrorMessage, exception.Message);
     }
 
     [PlaywrightTest("workers.spec.ts", "should report console logs")]

src/Playwright/API/Generated/IBrowser.cs

@@ -84,7 +84,8 @@ public partial interface IBrowser
     /// cref="IBrowser.NewContextAsync"/> **before** calling <see cref="IBrowser.CloseAsync"/>.
     /// </para>
     /// </remarks>
-    Task CloseAsync();
+    /// <param name="options">Call options</param>
+    Task CloseAsync(BrowserCloseOptions? options = default);
 
     /// <summary>
     /// <para>

src/Playwright/API/Generated/IBrowserContext.cs

@@ -266,7 +266,8 @@ public partial interface IBrowserContext
     /// </para>
     /// </summary>
     /// <remarks><para>The default browser context cannot be closed.</para></remarks>
-    Task CloseAsync();
+    /// <param name="options">Call options</param>
+    Task CloseAsync(BrowserContextCloseOptions? options = default);
 
     /// <summary>
     /// <para>

src/Playwright/API/Generated/IDownload.cs

@@ -63,7 +63,7 @@ public partial interface IDownload
     Task CancelAsync();
 
     /// <summary><para>Returns readable stream for current download or <c>null</c> if download failed.</para></summary>
-    Task<Stream?> CreateReadStreamAsync();
+    Task<Stream> CreateReadStreamAsync();
 
     /// <summary><para>Deletes the downloaded file. Will wait for the download to finish if necessary.</para></summary>
     Task DeleteAsync();
@@ -84,7 +84,7 @@ public partial interface IDownload
     /// to get suggested file name.
     /// </para>
     /// </summary>
-    Task<string?> PathAsync();
+    Task<string> PathAsync();
 
     /// <summary>
     /// <para>

src/Playwright/API/Generated/IFormData.cs

@@ -22,7 +22,6 @@
  * SOFTWARE.
  */
 
-
 #nullable enable
 
 namespace Microsoft.Playwright;

src/Playwright/API/Generated/IPlaywrightAssertions.cs

@@ -22,7 +22,6 @@
  * SOFTWARE.
  */
 
-
 #nullable enable
 
 namespace Microsoft.Playwright;

src/Playwright/API/Generated/IWebError.cs

@@ -22,7 +22,6 @@
  * SOFTWARE.
  */
 
-
 #nullable enable
 
 namespace Microsoft.Playwright;

src/Playwright/API/Generated/IWebSocketFrame.cs

@@ -22,7 +22,6 @@
  * SOFTWARE.
  */
 
-
 #nullable enable
 
 namespace Microsoft.Playwright;

src/Playwright/API/Generated/Options/BrowserCloseOptions.cs

@@ -0,0 +1,50 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) Microsoft Corporation.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+using System.Text.Json.Serialization;
+
+#nullable enable
+
+namespace Microsoft.Playwright;
+
+public class BrowserCloseOptions
+{
+    public BrowserCloseOptions() { }
+
+    public BrowserCloseOptions(BrowserCloseOptions clone)
+    {
+        if (clone == null)
+        {
+            return;
+        }
+
+        Reason = clone.Reason;
+    }
+
+    /// <summary><para>The reason to be reported to the operations interrupted by the browser closure.</para></summary>
+    [JsonPropertyName("reason")]
+    public string? Reason { get; set; }
+}
+
+#nullable disable

src/Playwright/API/Generated/Options/BrowserContextCloseOptions.cs

@@ -0,0 +1,50 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) Microsoft Corporation.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+using System.Text.Json.Serialization;
+
+#nullable enable
+
+namespace Microsoft.Playwright;
+
+public class BrowserContextCloseOptions
+{
+    public BrowserContextCloseOptions() { }
+
+    public BrowserContextCloseOptions(BrowserContextCloseOptions clone)
+    {
+        if (clone == null)
+        {
+            return;
+        }
+
+        Reason = clone.Reason;
+    }
+
+    /// <summary><para>The reason to be reported to the operations interrupted by the context closure.</para></summary>
+    [JsonPropertyName("reason")]
+    public string? Reason { get; set; }
+}
+
+#nullable disable

src/Playwright/API/Generated/Options/PageCloseOptions.cs

@@ -39,9 +39,14 @@ public PageCloseOptions(PageCloseOptions clone)
             return;
         }
 
+        Reason = clone.Reason;
         RunBeforeUnload = clone.RunBeforeUnload;
     }
 
+    /// <summary><para>The reason to be reported to the operations interrupted by the page closure.</para></summary>
+    [JsonPropertyName("reason")]
+    public string? Reason { get; set; }
+
     /// <summary>
     /// <para>
     /// Defaults to <c>false</c>. Whether to run the <a href="https://developer.mozilla.org/en-US/docs/Web/Events/beforeunload">before

src/Playwright/API/TargetClosedException.cs

@@ -0,0 +1,43 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) Microsoft Corporation.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+using System;
+using Microsoft.Playwright.Core;
+
+namespace Microsoft.Playwright;
+
+internal class TargetClosedException : PlaywrightException
+{
+    internal TargetClosedException() : base(DriverMessages.TargetClosedExceptionMessage)
+    {
+    }
+
+    internal TargetClosedException(string message) : base(message ?? DriverMessages.TargetClosedExceptionMessage)
+    {
+    }
+
+    internal TargetClosedException(string message, Exception innerException) : base(message, innerException)
+    {
+    }
+}