Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Allow to provide alternative host for browser downloads #1045

Closed
lukaszfiszer opened this issue Feb 17, 2020 · 0 comments · Fixed by #1179
Closed

[Feature] Allow to provide alternative host for browser downloads #1045

lukaszfiszer opened this issue Feb 17, 2020 · 0 comments · Fixed by #1179
Assignees
@aslushnikov

Comments

@lukaszfiszer
Copy link
Contributor

Puppeteer allowed to configure different download host for browser binaries via PUPPETEER_DOWNLOAD_HOST env variable. A similar settings should be made available in Playwright.

This feature is crucial for users behind corporate firewall, where downloading binaries from the internet is often blocked and internal mirror must be used instead.
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Mar 2, 2020
@aslushnikov
feat: support PLAYWRIGHT_DOWNLOAD_HOST
e761e5b 
This patch starts respecting `PLAYWRIGHT_DOWNLOAD_HOST` env variable
in `playwright` package and it's vendored flavors (`playwright-firefox`,
`playwright-chromium` and `playwright-webkit`).

Fixes microsoft#1045
@aslushnikov aslushnikov mentioned this issue Mar 2, 2020
Merged
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Mar 2, 2020
@aslushnikov
feat: support PLAYWRIGHT_DOWNLOAD_HOST
2125f12 
This patch starts respecting `PLAYWRIGHT_DOWNLOAD_HOST` env variable
in `playwright` package and it's vendored flavors (`playwright-firefox`,
`playwright-chromium` and `playwright-webkit`).

Fixes microsoft#1045
aslushnikov added a commit that referenced this issue Mar 2, 2020
@aslushnikov
feat: support PLAYWRIGHT_DOWNLOAD_HOST (#1179)
08fbc92 
This patch starts respecting `PLAYWRIGHT_DOWNLOAD_HOST` env variable
in `playwright` package and it's vendored flavors (`playwright-firefox`,
`playwright-chromium` and `playwright-webkit`).

Fixes #1045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslushnikov aslushnikov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support PLAYWRIGHT_DOWNLOAD_HOST aslushnikov/playwright
3 participants
@aslushnikov @pavelfeldman @lukaszfiszer