Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support PLAYWRIGHT_DOWNLOAD_HOST #1179

Merged

Conversation

aslushnikov
Copy link
Collaborator

This patch starts respecting PLAYWRIGHT_DOWNLOAD_HOST env variable
in playwright package and it's vendored flavors (playwright-firefox,
playwright-chromium and playwright-webkit).

Fixes #1045

This patch starts respecting `PLAYWRIGHT_DOWNLOAD_HOST` env variable
in `playwright` package and it's vendored flavors (`playwright-firefox`,
`playwright-chromium` and `playwright-webkit`).

Fixes microsoft#1045
@aslushnikov aslushnikov force-pushed the respect-environment-variables branch from e761e5b to 2125f12 Compare March 2, 2020 19:48
@@ -203,7 +205,7 @@ export class WebKit implements BrowserType {

const defaultOptions = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we follow up with removing BrowserFetcherOptions? We do not use anything but default.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sg

@aslushnikov aslushnikov merged commit 08fbc92 into microsoft:master Mar 2, 2020
@aslushnikov aslushnikov deleted the respect-environment-variables branch March 2, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Allow to provide alternative host for browser downloads
2 participants