Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] merge report action items #24451

Closed
15 tasks done
dgozman opened this issue Jul 27, 2023 · 0 comments · Fixed by #26473
Closed
15 tasks done

[internal] merge report action items #24451

dgozman opened this issue Jul 27, 2023 · 0 comments · Fixed by #26473
Assignees
@yury-s
Labels
v1.38

Comments

@dgozman
Copy link
Contributor

dgozman commented Jul 27, 2023 •
edited by yury-s
Loading

  • Document --config option.
  • When each shard runs the same setup project, it is merged incorrectly because of clashing test ids.
  • (internal) Do not put blob-report inside test-results.
  • Copy default blob-report location logic from html reporter - next to package.json.
  • Copy default report.md markdown report location logic from html reporter - next to package.json.
  • blob-report output directory should be removed at the start.
  • Document sharding+blob+merge yaml files.
  • Change the report.zip naming scheme with suffix and shard number.
  • OOM
  • Remove run_attempt from all yamls and docs.
  • Check playwright or blob versions from each shard and throw if they do not match.
  • Replace "projectSuffix" with "reportName".
  • Split onBegin per project (chore(blob): split onBegin into multiple onProject events #26329)
  • Update yaml in the docs to print the final report url from Azure.
  • Add GHA screenshots to the doc.
@dgozman dgozman added the v1.37 label Jul 27, 2023
@dgozman dgozman mentioned this issue Jul 27, 2023
Merged
dgozman added a commit that referenced this issue Jul 28, 2023
@dgozman
fix(merge): make sure testId from different blobs are unique (#24475)
9c70a75 
Fixes a scenario where each shard runs the same setup project.

References #24451.
@dgozman dgozman mentioned this issue Jul 28, 2023
Merged
dgozman added a commit that referenced this issue Jul 28, 2023
@dgozman
fix(blob report): default location relative to package.json (#24481)
d92fe16 
Also:
- remove `blob-report` directory at the start;
- markdown's `report.md` next to package.json;
- use default location in playwright's workflows.

References #24451.
@dgozman dgozman mentioned this issue Aug 5, 2023
Merged
@yury-s yury-s mentioned this issue Aug 5, 2023
Merged
yury-s added a commit that referenced this issue Aug 5, 2023
@yury-s
chore(merger): internalize json strings after parse (#25801)
f1f43c9 
Reference: #24451
dgozman added a commit that referenced this issue Aug 7, 2023
@dgozman
fix(blob): replace projectSuffix with reportName (#25017)
27c15b7 
Always ensure unique project/test ids across blobs.
Show `reportName` as a label in the html report.

References #24451.
@yury-s yury-s mentioned this issue Aug 7, 2023
Merged
yury-s added a commit that referenced this issue Aug 8, 2023
@yury-s
chore(merge): read test events from one file at a time (#26333)
0e20d35 
Reference #24451
@aslushnikov aslushnikov added v1.38 and removed v1.37 labels Aug 8, 2023
@yury-s yury-s mentioned this issue Aug 14, 2023
Merged
yury-s added a commit that referenced this issue Aug 14, 2023
@yury-s
docs(merge): add screenshot, print url, fix name (#26473)
f752952 
* Renamed test job to `playwright-tests` to match docs and rererences
* Added screenshot with github jobs and artifacts
* Print Azure URL

Fixes: #24451
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this issue Oct 27, 2023
@dgozman @Germandrummer92
fix(merge): make sure testId from different blobs are unique (microso…
33c3ff1 
…ft#24475)

Fixes a scenario where each shard runs the same setup project.

References microsoft#24451.
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this issue Oct 27, 2023
@dgozman @Germandrummer92
fix(blob report): default location relative to package.json (microsof…
da8ab7e 
…t#24481)

Also:
- remove `blob-report` directory at the start;
- markdown's `report.md` next to package.json;
- use default location in playwright's workflows.

References microsoft#24451.
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this issue Oct 27, 2023
@yury-s @Germandrummer92
chore(merger): internalize json strings after parse (microsoft#25801)
e978688 
Reference: microsoft#24451
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this issue Oct 27, 2023
@dgozman @Germandrummer92
fix(blob): replace projectSuffix with reportName (microsoft#25017)
59a26ee 
Always ensure unique project/test ids across blobs.
Show `reportName` as a label in the html report.

References microsoft#24451.
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this issue Oct 27, 2023
@yury-s @Germandrummer92
chore(merge): read test events from one file at a time (microsoft#26333)
88a07ae 
Reference microsoft#24451
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this issue Oct 27, 2023
@yury-s @Germandrummer92
docs(merge): add screenshot, print url, fix name (microsoft#26473)
0429cbf 
* Renamed test job to `playwright-tests` to match docs and rererences
* Added screenshot with github jobs and artifacts
* Print Azure URL

Fixes: microsoft#24451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yury-s yury-s

Labels
v1.38
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(merge): add screenshot, print url, fix name yury-s/playwright
3 participants
@aslushnikov @yury-s @dgozman