Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(merge): read test events from one file at a time #26333

Merged
merged 2 commits into from
Aug 8, 2023
Merged

chore(merge): read test events from one file at a time #26333

merged 2 commits into from
Aug 8, 2023

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Aug 7, 2023

Reference #24451

dgozman
dgozman approved these changes Aug 7, 2023
View reviewed changes
packages/playwright-test/src/reporters/merge.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Test results for "tests 1"

1 failed
❌ [playwright-test] › ui-mode-trace.spec.ts:53:5 › should merge web assertion events

8 flaky
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/inspector/cli-codegen-python.spec.ts:74:5 › should save the codegen output to a file if specified
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:218:5 › should show trace w/ multiple contexts

25040 passed, 583 skipped
✔️✔️✔️

❌ [playwright-test] › ui-mode-trace.spec.ts:53:5 › should merge web assertion events 

Error: action list

- Expected  -  6
+ Received  + 10

  Array [
-   /Before Hooks[\d.]+m?s/,
-   /page.setContent[\d.]+m?s/,
-   /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,
-   /After Hooks[\d.]+m?s/,
-   /fixture: page[\d.]+m?s/,
-   /fixture: context[\d.]+m?s/,
+   "Before Hooks827ms",
+   "fixture: browser514ms",
+   "fixture: context56ms",
+   "fixture: page205ms",
+   "browserContext.newPage164ms",
+   "page.setContent69ms",
+   "expect.toBeVisiblelocator('button')94ms",
+   "After Hooks1ms",
+   "fixture: page0ms",
+   "fixture: context0ms",
  ]
Call log:
  - locator._expect with timeout 75000ms
  - waiting for getByTestId('action-list').getByRole('listitem')
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 8 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements


  68 |       listItem,
  69 |       'action list'
> 70 |   ).toHaveText([
     |     ^
  71 |     /Before Hooks[\d.]+m?s/,
  72 |     /page.setContent[\d.]+m?s/,
  73 |     /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,

    at /Users/runner/work/playwright/playwright/tests/playwright-test/ui-mode-trace.spec.ts:70:5

Retry 1:

Error: action list

- Expected  -  6
+ Received  + 10

  Array [
-   /Before Hooks[\d.]+m?s/,
-   /page.setContent[\d.]+m?s/,
-   /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,
-   /After Hooks[\d.]+m?s/,
-   /fixture: page[\d.]+m?s/,
-   /fixture: context[\d.]+m?s/,
+   "Before Hooks881ms",
+   "fixture: browser525ms",
+   "fixture: context43ms",
+   "fixture: page258ms",
+   "browserContext.newPage233ms",
+   "page.setContent62ms",
+   "expect.toBeVisiblelocator('button')33ms",
+   "After Hooks1ms",
+   "fixture: page0ms",
+   "fixture: context0ms",
  ]
Call log:
  - locator._expect with timeout 75000ms
  - waiting for getByTestId('action-list').getByRole('listitem')
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements


  68 |       listItem,
  69 |       'action list'
> 70 |   ).toHaveText([
     |     ^
  71 |     /Before Hooks[\d.]+m?s/,
  72 |     /page.setContent[\d.]+m?s/,
  73 |     /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,

    at /Users/runner/work/playwright/playwright/tests/playwright-test/ui-mode-trace.spec.ts:70:5

Retry 2:

Error: action list

- Expected  -  6
+ Received  + 10

  Array [
-   /Before Hooks[\d.]+m?s/,
-   /page.setContent[\d.]+m?s/,
-   /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,
-   /After Hooks[\d.]+m?s/,
-   /fixture: page[\d.]+m?s/,
-   /fixture: context[\d.]+m?s/,
+   "Before Hooks1.0s",
+   "fixture: browser585ms",
+   "fixture: context72ms",
+   "fixture: page338ms",
+   "browserContext.newPage317ms",
+   "page.setContent26ms",
+   "expect.toBeVisiblelocator('button')31ms",
+   "After Hooks2ms",
+   "fixture: page0ms",
+   "fixture: context0ms",
  ]
Call log:
  - locator._expect with timeout 75000ms
  - waiting for getByTestId('action-list').getByRole('listitem')
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements


  68 |       listItem,
  69 |       'action list'
> 70 |   ).toHaveText([
     |     ^
  71 |     /Before Hooks[\d.]+m?s/,
  72 |     /page.setContent[\d.]+m?s/,
  73 |     /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,

    at /Users/runner/work/playwright/playwright/tests/playwright-test/ui-mode-trace.spec.ts:70:5

Retry 3:

Error: action list

- Expected  -  6
+ Received  + 10

  Array [
-   /Before Hooks[\d.]+m?s/,
-   /page.setContent[\d.]+m?s/,
-   /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,
-   /After Hooks[\d.]+m?s/,
-   /fixture: page[\d.]+m?s/,
-   /fixture: context[\d.]+m?s/,
+   "Before Hooks928ms",
+   "fixture: browser527ms",
+   "fixture: context71ms",
+   "fixture: page265ms",
+   "browserContext.newPage252ms",
+   "page.setContent28ms",
+   "expect.toBeVisiblelocator('button')30ms",
+   "After Hooks2ms",
+   "fixture: page0ms",
+   "fixture: context0ms",
  ]
Call log:
  - locator._expect with timeout 75000ms
  - waiting for getByTestId('action-list').getByRole('listitem')
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 0 elements
  -   locator resolved to 1 element
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements
  -   locator resolved to 10 elements


  68 |       listItem,
  69 |       'action list'
> 70 |   ).toHaveText([
     |     ^
  71 |     /Before Hooks[\d.]+m?s/,
  72 |     /page.setContent[\d.]+m?s/,
  73 |     /expect.toBeVisiblelocator\('button'\)[\d.]+m?s/,

    at /Users/runner/work/playwright/playwright/tests/playwright-test/ui-mode-trace.spec.ts:70:5

Merge workflow run.

@yury-s yury-s merged commit 0e20d35 into microsoft:main Aug 8, 2023
27 of 28 checks passed
@yury-s yury-s deleted the stream-events branch August 8, 2023 00:39
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
@yury-s @Germandrummer92
chore(merge): read test events from one file at a time (microsoft#26333)
88a07ae 
Reference microsoft#24451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yury-s @dgozman