Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] there's no good way to match published @next npm package back to its source #3743

Closed
aslushnikov opened this issue Sep 2, 2020 · 1 comment · Fixed by #3754
Closed

[BUG] there's no good way to match published @next npm package back to its source #3743

aslushnikov opened this issue Sep 2, 2020 · 1 comment · Fixed by #3754

Comments

@aslushnikov
Copy link
Contributor

We should bake SHA somewhere into the packages. Or maybe it's already baked somewhere?.. Explore & bake in if necessary.
@mxschmitt
Copy link
Member

+1 for that. In the RPC driver world before we had the unified driver (we will expose there something like --version) we thought about adding a the Git hash to the package.json so we could access it during the runtime.

aslushnikov added a commit to aslushnikov/playwright that referenced this issue Sep 3, 2020
@aslushnikov
devops: bake commit SHA inside npm package
05f0c3e 
This bakes in `//commitinfo` file with the SHA of the commit that
produced given NPM package.

Fixes microsoft#3743
@aslushnikov aslushnikov mentioned this issue Sep 3, 2020
Merged
aslushnikov added a commit that referenced this issue Sep 3, 2020
@aslushnikov
devops: bake commit SHA inside npm package (#3754)
5364e32 
This bakes in `//commitinfo` file with the SHA of the commit that
produced given NPM package.

Fixes #3743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

devops: bake commit SHA inside npm package aslushnikov/playwright
2 participants
@aslushnikov @mxschmitt