Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devops: bake commit SHA inside npm package #3754

Merged
merged 1 commit into from
Sep 3, 2020
Merged

devops: bake commit SHA inside npm package #3754

merged 1 commit into from
Sep 3, 2020

Conversation

aslushnikov
Copy link
Contributor

This bakes in //commitinfo file with the SHA of the commit that
produced given NPM package.

Fixes #3743

@aslushnikov
devops: bake commit SHA inside npm package
05f0c3e 
This bakes in `//commitinfo` file with the SHA of the commit that
produced given NPM package.

Fixes microsoft#3743
mxschmitt
mxschmitt approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why not adding it to the package.json?

@aslushnikov
Copy link
Contributor Author

Out of curiosity, why not adding it to the package.json?

package.json fields can be overwritten / used in future by some other tooling, so I'd rather not mess with that universe.

@aslushnikov aslushnikov merged commit 5364e32 into microsoft:master Sep 3, 2020
@aslushnikov aslushnikov deleted the bake-commit-sha-into-npm-package branch September 3, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] there's no good way to match published @next npm package back to its source
3 participants
@aslushnikov @dgozman @mxschmitt