browser(webkit): properly disconnect signal handlers when closing browser #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yury-s/WebKit@0c258cd
This fixes following crash in
"WebKit browserType.launch({downloadsPath}) should keep downloadsPath folder (downloadsPath.spec.js:46:3)":
#0 0x00007f4072b28e4d in g_type_check_instance () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libgobject-2.0.so.0
#1 0x00007f4072b1ca34 in g_signal_handlers_disconnect_matched () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libgobject-2.0.so.0
#2 0x000056033590193b in ?? ()
#3 0x00007f4072b01c2d in g_closure_invoke () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libgobject-2.0.so.0
#4 0x00007f4072b1562e in ?? () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libgobject-2.0.so.0
#5 0x00007f4072b1dfe5 in g_signal_emit_valist () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libgobject-2.0.so.0
#6 0x00007f4072b1e9ff in g_signal_emit () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libgobject-2.0.so.0
#7 0x00007f4076edaafb in webkitDownloadFailed(_WebKitDownload*, WebCore::ResourceError const&) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37
#8 0x00007f4076edb9fe in webkitDownloadCancelled(_WebKitDownload*) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37
#9 0x00007f4076edc1e9 in DownloadClient::didCancel(WebKit::DownloadProxy&) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37
#10 0x00007f4076f614b5 in WebKit::DownloadProxy::didCancel(IPC::DataReference const&) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37
#11 0x00007f4076b014e1 in WebKit::DownloadProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37
#12 0x00007f4076d0b5f8 in IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37
#13 0x00007f4076f74fbf in non-virtual thunk to WebKit::NetworkProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37
#14 0x00007f4076d03f90 in IPC::Connection::dispatchMessage(IPC::Decoder&) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37
#15 0x00007f4076d05d25 in IPC::Connection::dispatchMessage(std::unique_ptr<IPC::Decoder, std::default_deleteIPC::Decoder >) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37
#16 0x00007f4076d064cf in IPC::Connection::dispatchOneIncomingMessage() () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37
#17 0x00007f4074940df5 in WTF::RunLoop::performWork() () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libjavascriptcoregtk-4.0.so.18
#18 0x00007f40749a9b09 in ?? () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libjavascriptcoregtk-4.0.so.18
#19 0x00007f407ab639e5 in g_main_context_dispatch () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libglib-2.0.so.0
#20 0x00007f407ab63db0 in ?? () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libglib-2.0.so.0
#21 0x00007f407ab63e3c in g_main_context_iteration () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libglib-2.0.so.0
#22 0x00007f4072e1069d in g_application_run () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libgio-2.0.so.0
#23 0x00005603358ff76f in ?? ()
#24 0x00007f4071b30b97 in __libc_start_main (main=0x5603358ff320, argc=3, argv=0x7ffd6d806508, init=, fini=, rtld_fini=, stack_end=0x7ffd6d8064f8) at ../csu/libc-start.c:310
#25 0x00005603358ff81a in ?? ()