Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser(webkit): properly disconnect signal handlers when closing browser #2849

Merged
merged 1 commit into from
Jul 6, 2020
Merged

browser(webkit): properly disconnect signal handlers when closing browser #2849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions browser_patches/webkit/BUILD_NUMBER
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
1301
Changed: lushnikov@chromium.org Thu Jul 2 15:14:04 PDT 2020
1302
Changed: yurys@chromium.org Mon Jul 6 13:55:53 PDT 2020
12 changes: 12 additions & 0 deletions browser_patches/webkit/patches/bootstrap.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15030,6 +15030,18 @@ index 113170ce21145fc53a3c804822ef20fa9d89de8b..855ff101965bf1dd652d58903db0c143
# TODO: Add a check for HAVE_RSA_PSS for support of CryptoAlgorithmRSA_PSS
# https://bugs.webkit.org/show_bug.cgi?id=206635

diff --git a/Tools/MiniBrowser/gtk/BrowserDownloadsBar.c b/Tools/MiniBrowser/gtk/BrowserDownloadsBar.c
index b9feb8e7d97716ff505c3ce0d3bea830ff0a9d62..91d83beeb8b6350f1a03551f638df65af838c2aa 100644
--- a/Tools/MiniBrowser/gtk/BrowserDownloadsBar.c
+++ b/Tools/MiniBrowser/gtk/BrowserDownloadsBar.c
@@ -127,6 +127,7 @@ static void browserDownloadFinalize(GObject *object)
BrowserDownload *browserDownload = BROWSER_DOWNLOAD(object);

if (browserDownload->download) {
+ g_signal_handlers_disconnect_by_data(browserDownload->download, browserDownload);
g_object_unref(browserDownload->download);
browserDownload->download = NULL;
}
diff --git a/Tools/MiniBrowser/gtk/BrowserTab.c b/Tools/MiniBrowser/gtk/BrowserTab.c
index 3845eabba3e964f9e11bb0ffcb8726fd4ea96fc4..630a6e395298bd9c03c1b131f984b0a8444d2051 100644
--- a/Tools/MiniBrowser/gtk/BrowserTab.c
Expand Down