Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops: use ubuntu focal on bots and docs #5951

Merged

Conversation

mxschmitt
Copy link
Member

  • drive-by: updated NPM Action
  • replaced ubuntu-latest by ubuntu-20 so its pinned

Extracted from #5746

@mxschmitt
Copy link
Member Author

mxschmitt commented Mar 26, 2021

Firefox on ubuntu 20 with headful does not work with WebGL. Seems like a missing dependency there maybe?

@mxschmitt mxschmitt force-pushed the devops/use-ubuntu-20-on-bots branch from cad5845 to ef09f18 Compare March 26, 2021 09:31
@mxschmitt mxschmitt force-pushed the devops/use-ubuntu-20-on-bots branch from ef09f18 to fb7ceff Compare March 30, 2021 09:06
@mxschmitt
Copy link
Member Author

mxschmitt commented Apr 2, 2021

@aslushnikov
I tested if WebGL in Firefox (the failing tests) would work on Ubuntu 20 headed on the last 10 PW versions, on all the versions it's not working. Should I simply adjust the test.fixme so its test.fixme(browserName === 'firefox'); instead of test.fixme(browserName === 'firefox' && !headful);?

Its running inside that if: https://ffsearch.azurewebsites.net/#path=%2Fhome%2Fjoe%2Fplaywright%2Fbrowser_patches%2Ffirefox%2Fcheckout%2Fdom%2Fcanvas%2FWebGLContext.cpp&line=343

Update: Can be landed, a custom ubuntu20 FF build was setup.

aslushnikov added a commit to aslushnikov/playwright that referenced this pull request Apr 2, 2021
This will fix webgl issues with headful firefox on Ubuntu 20.04

See
microsoft#5951 (comment)
aslushnikov added a commit that referenced this pull request Apr 2, 2021
This will fix webgl issues with headful firefox on Ubuntu 20.04

See
#5951 (comment)
- drive-by: updated NPM Action
@mxschmitt mxschmitt force-pushed the devops/use-ubuntu-20-on-bots branch from fb7ceff to 0145c08 Compare April 3, 2021 07:22
@aslushnikov aslushnikov merged commit af48a8a into microsoft:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants