Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops: use ubuntu focal on bots and docs #5951

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/infra.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ on:
jobs:
doc-and-lint:
name: "docs & lint"
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10
- uses: microsoft/playwright-github-action@v1
Expand All @@ -36,7 +36,7 @@ jobs:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10
- uses: microsoft/playwright-github-action@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_canary_docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
username: playwright
password: ${{ secrets.DOCKER_PASSWORD }}
- uses: microsoft/playwright-github-action@v1
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10.15
- run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_canary_driver.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
if: github.repository == 'microsoft/playwright'
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 12.x
registry-url: 'https://registry.npmjs.org'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish_canary_npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ on:
jobs:
publish-canary-npm:
name: "publish to NPM"
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
if: github.repository == 'microsoft/playwright'
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10
registry-url: 'https://registry.npmjs.org'
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/publish_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ on:
jobs:
publish-npm-release:
name: "publish to NPM"
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
if: github.repository == 'microsoft/playwright'
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10
registry-url: 'https://registry.npmjs.org'
Expand All @@ -28,7 +28,7 @@ jobs:
if: github.repository == 'microsoft/playwright'
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 12.x
registry-url: 'https://registry.npmjs.org'
Expand All @@ -55,7 +55,7 @@ jobs:
username: playwright
password: ${{ secrets.DOCKER_PASSWORD }}
- uses: microsoft/playwright-github-action@v1
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10.15
- run: npm ci
Expand Down
36 changes: 17 additions & 19 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10
- run: npm ci
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10
- run: npm ci
Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:
shell: powershell
run: Install-WindowsFeature Server-Media-Foundation
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10
- run: npm ci
Expand All @@ -125,7 +125,7 @@ jobs:
path: test-results

test-package-installations:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
strategy:
fail-fast: false
matrix:
Expand All @@ -135,7 +135,7 @@ jobs:
- "^14.1.0" # pre 14.1, zip extraction was broken (https://github.com/microsoft/playwright/issues/1988)
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node_version }}
- run: npm ci
Expand All @@ -149,10 +149,10 @@ jobs:
fail-fast: false
matrix:
browser: [chromium, firefox, webkit]
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10
- run: npm ci
Expand Down Expand Up @@ -189,10 +189,10 @@ jobs:
fail-fast: false
matrix:
mode: [driver, service]
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10
- run: npm ci
Expand Down Expand Up @@ -227,10 +227,10 @@ jobs:
fail-fast: false
matrix:
browser: [chromium, firefox, webkit]
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10
- run: npm ci
Expand Down Expand Up @@ -266,7 +266,7 @@ jobs:
PW_ANDROID_TESTS: 1
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 14
- run: npm ci
Expand All @@ -288,12 +288,10 @@ jobs:

chrome_stable_linux:
name: "Chrome Stable (Linux)"
strategy:
fail-fast: false
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10
- name: Install Chrome Stable
Expand Down Expand Up @@ -334,7 +332,7 @@ jobs:
shell: powershell
run: Install-WindowsFeature Server-Media-Foundation
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10
- run: npm ci
Expand Down Expand Up @@ -365,7 +363,7 @@ jobs:
runs-on: macos-10.15
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10
- run: npm ci
Expand Down Expand Up @@ -397,7 +395,7 @@ jobs:
shell: powershell
run: Install-WindowsFeature Server-Media-Foundation
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 10
- run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trigger_build_chromium.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
trigger:
name: "trigger"
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- run: |
curl -X POST \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
trigger:
name: "trigger"
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- run: |
curl -X POST \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trigger_build_ffmpeg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
trigger:
name: "trigger"
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- run: |
curl -X POST \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trigger_build_firefox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
trigger:
name: "trigger"
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- run: |
curl -X POST \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trigger_build_webkit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
trigger:
name: "trigger"
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- run: |
curl -X POST \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trigger_build_winldd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
trigger:
name: "trigger"
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- run: |
curl -X POST \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trigger_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:
trigger:
name: "trigger"
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- run: |
curl -X POST \
Expand Down
12 changes: 6 additions & 6 deletions docs/src/ci.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,9 @@ For Linux agents, you can use [our Docker container](./docker.md) with Azure Pip

```yml
pool:
vmImage: 'ubuntu-18.04'
vmImage: 'ubuntu-20.04'

container: mcr.microsoft.com/playwright:bionic
container: mcr.microsoft.com/playwright:focal

steps:
...
Expand Down Expand Up @@ -189,7 +189,7 @@ Running Playwright on CircleCI requires the following steps:

```yml
docker:
- image: mcr.microsoft.com/playwright:bionic
- image: mcr.microsoft.com/playwright:focal
environment:
NODE_ENV: development # Needed if playwright is in `devDependencies`
```
Expand All @@ -211,7 +211,7 @@ to run tests on Jenkins.

```groovy
pipeline {
agent { docker { image 'mcr.microsoft.com/playwright:bionic' } }
agent { docker { image 'mcr.microsoft.com/playwright:focal' } }
stages {
stage('e2e-tests') {
steps {
Expand All @@ -228,7 +228,7 @@ pipeline {
Bitbucket Pipelines can use public [Docker images as build environments](https://confluence.atlassian.com/bitbucket/use-docker-images-as-build-environments-792298897.html). To run Playwright tests on Bitbucket, use our public Docker image ([see Dockerfile](./docker.md)).

```yml
image: mcr.microsoft.com/playwright:bionic
image: mcr.microsoft.com/playwright:focal
```

While the Docker image supports sandboxing for Chromium, it does not work in the Bitbucket Pipelines environment. To launch Chromium on Bitbucket Pipelines, use the `chromiumSandbox: false` launch argument.
Expand Down Expand Up @@ -269,7 +269,7 @@ stages:

tests:
stage: test
image: mcr.microsoft.com/playwright:bionic
image: mcr.microsoft.com/playwright:focal
script:
...
```
Expand Down
2 changes: 1 addition & 1 deletion docs/src/docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ This image is published on [Docker Hub](https://hub.docker.com/_/microsoft-playw
### Pull the image

```
$ docker pull mcr.microsoft.com/playwright:bionic
docker pull mcr.microsoft.com/playwright:focal
```

### Run the image
Expand Down