CodePushDemoApp update to latest RN #1054
Conversation
…odePushDemoApp-pre0.49
| "dependencies": { | ||
| "react": "16.0.0-alpha.12", | ||
| "react-native": "^0.47.1", | ||
| "react-native-code-push": "file:../../", |
There was a problem hiding this comment.
RNCP version should be fixed here
There was a problem hiding this comment.
This is done in accordance with previous implementation (seems make sense to test against local copy of RN)
There was a problem hiding this comment.
@max-mironov okay i got it
| }, | ||
| "dependencies": { | ||
| "react": "16.0.0-alpha.12", | ||
| "react-native": "^0.47.1", |
There was a problem hiding this comment.
May be we should use latest pre 0.49 RN version here (i mean 0.48.4)?
There was a problem hiding this comment.
Don't see any differences within these two versions in comparison of configuration/usage, so not sure if this change is required
There was a problem hiding this comment.
@max-mironov okay, nevermind
| "react-native-windows": "^0.43.0-rc.0" | ||
| "react": "16.0.0-beta.5", | ||
| "react-native": "^0.49.3", | ||
| "react-native-code-push": "file:../../" |
There was a problem hiding this comment.
react-native-windows is missing here
There was a problem hiding this comment.
@max-mironov I think we should land this PR first #1051
There was a problem hiding this comment.
I'd like to add this later, in another PR, so we keep previous version of react-native-windows in old CodePushDemoApp-pre0.49 and we should test and upgrade to latest react-native-windows separately for newly created demo app.
There was a problem hiding this comment.
@max-mironov okay reasonable
Added new CodePushDemoApp for RN 0.49 and upper. Rename old demo to CodePushDemoApp-pre0.49