Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CodePush for react-native-windows v0.50+ #1051

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

rozele
Copy link
Contributor

@rozele rozele commented Oct 17, 2017

In react-native-windows v0.50+, we added ReactNativeHost, which has better support for running React Native in the background as well as embedding React Native in other controls besides XAML Pages.

Please don't merge this until microsoft/react-native-windows#1445 is merged and react-native-windows v0.50 is released (I'll ping back here when that is the case).

@sergey-akhalkov
Copy link
Contributor

Hi @rozele, got it, thanks for the contribution!

In react-native-windows v0.50+, we added ReactNativeHost, which has better support for running React Native in the background as well as embedding React Native in other controls besides XAML Pages.
@rozele
Copy link
Contributor Author

rozele commented Oct 19, 2017

Also this breaking change will hopefully land in v0.50 - microsoft/react-native-windows#1458. Added the necessary changes for that as well.

@Jacse
Copy link

Jacse commented Nov 5, 2017

@rozele shouldn't this be merged now react-native@0.50.1 is out?

@ruslan-bikkinin
Copy link
Contributor

@Jacse Yes we will merge it soon!

@ruslan-bikkinin
Copy link
Contributor

@Jacse I mean when react-native-windows version 0.50 will be released 😉

@Jacse
Copy link

Jacse commented Nov 7, 2017

@ruslan-bikkinin ahh 😄

@adricl
Copy link

adricl commented Nov 13, 2017

Can this please be merged now as react-native-windows version 0.50 has now been released! Thanks so much for your hard work.

@max-mironov
Copy link
Contributor

@adricl thanks for update, will do really soon.

@rozele - can you please confirm that fix is landed in latest release?
Also just curious - in your release history you have always rc versions and sometimes not (like here). So on which conditions it depends on?

@sergey-akhalkov
Copy link
Contributor

Hi @rozele , just a friendly ping regarding this question:

@rozele - can you please confirm that fix is landed in latest release?
Also just curious - in your release history you have always rc versions and sometimes not (like here). So on which conditions it depends on?

@rozele
Copy link
Contributor Author

rozele commented Nov 16, 2017

Thanks @sergey-akhalkov, this is ready to merge. No real reason for not having official releases. We stopped having stable releases after 0.42 primarily because of limited time, but I was hoping to get back on the React Native cadence, publishing RCs simultaneously with theirs, and stable at the end of the month, just been hard to catch up.

@sergey-akhalkov
Copy link
Contributor

@rozele , got it, thanks for the clarification, going to merge it and release an update tomorrow or in the beginning of the next week.

@sergey-akhalkov sergey-akhalkov merged commit cf36d1c into microsoft:master Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants