refactor(ReactInstanceManager): Support awaitable ReactContext #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1458 +/- ##
==========================================
- Coverage 31.54% 31.47% -0.08%
==========================================
Files 266 266
Lines 19253 19296 +43
Branches 1599 1613 +14
==========================================
Hits 6073 6073
- Misses 13030 13072 +42
- Partials 150 151 +1
Continue to review full report at Codecov.
|
rozele
force-pushed
the
issue1448
branch
9 times, most recently
from
aab8588
to
af1b893
Compare
rozele
commented
Oct 19, 2017
| @@ -0,0 +1,32 @@ | |||
| using ReactNative.Bridge; | |||
| using ReactNative.DevSupport; | |||
| using System; | |||
There was a problem hiding this comment.
Delete unused usings. #Closed
rozele
commented
Oct 19, 2017
| @@ -110,7 +111,7 @@ public void StartReactApplication(ReactInstanceManager reactInstanceManager, str | |||
|
|
|||
| if (!_reactInstanceManager.HasStartedCreatingInitialContext) | |||
| { | |||
| _reactInstanceManager.CreateReactContextInBackground(); | |||
| _reactInstanceManager.CreateReactContextAsync(CancellationToken.None); | |||
There was a problem hiding this comment.
CreateReactContextAsync [](start = 38, length = 23)
Likely has a warning, will need to await the task. #Closed
rozele
commented
Oct 19, 2017
| { | ||
| var moved = false; | ||
| #if WINDOWS_UWP | ||
| var temporaryFile = await ApplicationData.Current.TemporaryFolder.CreateFileAsync(JSBundleFileName, CreationCollisionOption.GenerateUniqueName); | ||
| var temporaryFile = await ApplicationData.Current.TemporaryFolder.CreateFileAsync(JSBundleFileName, CreationCollisionOption.GenerateUniqueName).AsTask(token); | ||
| try | ||
| { | ||
| using (var stream = await temporaryFile.OpenStreamForWriteAsync()) | ||
| { | ||
| await _devServerHelper.DownloadBundleFromUrlAsync(_jsAppBundleName, stream, token); |
There was a problem hiding this comment.
DownloadBundleFromUrlAsync [](start = 43, length = 26)
Add ConfigureAwaits #Closed
rozele
commented
Oct 19, 2017
| await temporaryFile.MoveAsync( | ||
| ApplicationData.Current.LocalFolder, | ||
| JSBundleFileName, | ||
| NameCollisionOption.ReplaceExisting).AsTask(); |
There was a problem hiding this comment.
AsTask [](start = 57, length = 6)
Add comment about why CancellationToken not used here. #Closed
rozele
commented
Oct 19, 2017
|
|
||
| return await _reactInstanceCommandsHandler.CreateReactContextWithRemoteDebuggerAsync(factory, token); | ||
| } | ||
| finally |
There was a problem hiding this comment.
finally [](start = 12, length = 7)
May need to catch some exceptions here... #Closed
rozele
commented
Oct 31, 2017
| @@ -110,7 +111,7 @@ public void StartReactApplication(ReactInstanceManager reactInstanceManager, str | |||
|
|
|||
| if (!_reactInstanceManager.HasStartedCreatingInitialContext) | |||
| { | |||
| _reactInstanceManager.CreateReactContextInBackground(); | |||
| _reactInstanceManager.CreateReactContextAsync(CancellationToken.None); | |||
| } | |||
There was a problem hiding this comment.
GetOrCreate #Closed
Currently, the ReactInstanceManager kicks off the process to create the ReactContext in the background and its not awaitable. This ensures a single asynchronous thread is available from start to finish for ReactContext creation. Fixes microsoft#1448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the ReactInstanceManager kicks off the process to create the ReactContext in the background and its not awaitable. This ensures a single asynchronous thread is available from start to finish for ReactContext creation.
Fixes #1448