forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spellCheck and autoCorrect props #1292
Merged
Saadnajmi
merged 1 commit into
microsoft:main
from
christophpurrer:fixSpellCheckAndAutoCorrect
Jul 26, 2022
Merged
Fix spellCheck and autoCorrect props #1292
Saadnajmi
merged 1 commit into
microsoft:main
from
christophpurrer:fixSpellCheckAndAutoCorrect
Jul 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This fixes `autoCorrect` to correctly map to `automaticSpellingCorrectionEnabled`, and `spellCheck` to map to `continuousSpellCheckingEnabled`. Note: automaticTextReplacementEnabled is a different feature than automaticSpellingCorrectionEnabled https://developer.apple.com/documentation/appkit/nstextview/1449210-automatictextreplacementenabled https://developer.apple.com/documentation/appkit/nstextview/1449254-isautomaticspellingcorrectionena
harrieshin
approved these changes
Jul 25, 2022
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 25, 2022
Similar to microsoft#1292 this adds a macOS only property to toggle grammarCheck on RCTUITextField
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 25, 2022
Similar to microsoft#1292 this adds a macOS only property to toggle grammarCheck on RCTUITextField
4 tasks
Saadnajmi
approved these changes
Jul 26, 2022
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 26, 2022
Similar to microsoft#1292 this adds a macOS only property to toggle grammarCheck on RCTUITextField
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 26, 2022
Similar to microsoft#1292 this adds a macOS only property to toggle grammarCheck on RCTUITextField
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 9, 2022
Summary: This fixes `autoCorrect` to correctly map to `automaticSpellingCorrectionEnabled`, and `spellCheck` to map to `continuousSpellCheckingEnabled`. Note: automaticTextReplacementEnabled is a different feature than automaticSpellingCorrectionEnabled https://developer.apple.com/documentation/appkit/nstextview/1449210-automatictextreplacementenabled https://developer.apple.com/documentation/appkit/nstextview/1449254-isautomaticspellingcorrectionena Co-authored-by: Scott Kyle <skyle@fb.com> # Conflicts: # Libraries/Text/TextInput/Singleline/RCTUITextField.h # Libraries/Text/TextInput/Singleline/RCTUITextField.m
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 9, 2022
Summary: This fixes `autoCorrect` to correctly map to `automaticSpellingCorrectionEnabled`, and `spellCheck` to map to `continuousSpellCheckingEnabled`. Note: automaticTextReplacementEnabled is a different feature than automaticSpellingCorrectionEnabled https://developer.apple.com/documentation/appkit/nstextview/1449210-automatictextreplacementenabled https://developer.apple.com/documentation/appkit/nstextview/1449254-isautomaticspellingcorrectionena Co-authored-by: Scott Kyle <skyle@fb.com> # Conflicts: # Libraries/Text/TextInput/Singleline/RCTUITextField.h # Libraries/Text/TextInput/Singleline/RCTUITextField.m
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 10, 2022
Summary: This fixes `autoCorrect` to correctly map to `automaticSpellingCorrectionEnabled`, and `spellCheck` to map to `continuousSpellCheckingEnabled`. Note: automaticTextReplacementEnabled is a different feature than automaticSpellingCorrectionEnabled https://developer.apple.com/documentation/appkit/nstextview/1449210-automatictextreplacementenabled https://developer.apple.com/documentation/appkit/nstextview/1449254-isautomaticspellingcorrectionena Co-authored-by: Scott Kyle <skyle@fb.com> # Conflicts: # Libraries/Text/TextInput/Singleline/RCTUITextField.h # Libraries/Text/TextInput/Singleline/RCTUITextField.m
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
Summary: This fixes `autoCorrect` to correctly map to `automaticSpellingCorrectionEnabled`, and `spellCheck` to map to `continuousSpellCheckingEnabled`. Note: automaticTextReplacementEnabled is a different feature than automaticSpellingCorrectionEnabled https://developer.apple.com/documentation/appkit/nstextview/1449210-automatictextreplacementenabled https://developer.apple.com/documentation/appkit/nstextview/1449254-isautomaticspellingcorrectionena Co-authored-by: Scott Kyle <skyle@fb.com>
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
Summary: This fixes `autoCorrect` to correctly map to `automaticSpellingCorrectionEnabled`, and `spellCheck` to map to `continuousSpellCheckingEnabled`. Note: automaticTextReplacementEnabled is a different feature than automaticSpellingCorrectionEnabled https://developer.apple.com/documentation/appkit/nstextview/1449210-automatictextreplacementenabled https://developer.apple.com/documentation/appkit/nstextview/1449254-isautomaticspellingcorrectionena Co-authored-by: Scott Kyle <skyle@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This fixes
autoCorrect
to correctly map toautomaticSpellingCorrectionEnabled
, andspellCheck
to map tocontinuousSpellCheckingEnabled
.Note: automaticTextReplacementEnabled is a different feature than automaticSpellingCorrectionEnabled
https://developer.apple.com/documentation/appkit/nstextview/1449210-automatictextreplacementenabled
https://developer.apple.com/documentation/appkit/nstextview/1449254-isautomaticspellingcorrectionena
Changelog
[macOS] [Fixed] - Fix spellCheck and autoCorrect props
Test Plan
Using this sample
Before
Errors shown in 00:00:02 and 00:00:06
before.mov
After
Works as anticipated
Screen.Recording.2022-07-25.at.3.43.29.PM.mov