Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass grammarCheck to text input views for Mac #1293

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

christophpurrer
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Similar to #1292 this adds a macOS only property to toggle grammarCheck on RCTUITextField

Changelog

[macOS] [Added] - Pass grammarCheck to text input views for Mac

Test Plan

Using this sample

  {
    title: 'Auto-focus',
    render: function (): React.Node {
      return (
      <>
        <TextInput
          spellCheck={true}
          style={{backgroundColor: 'white', margin: 10}}
          accessibilityLabel="spellCheck"
        />        
        <TextInput
          grammarCheck={true}
          style={{backgroundColor: 'white', margin: 10}}
          accessibilityLabel="grammarCheck"
        />
        <TextInput
          autoCorrect={true}
          style={{backgroundColor: 'white', margin: 10}}
          accessibilityLabel="autoFocus"
        />
        <View style={{margin: 50, width:200, height:100, backgroundColor: 'red'}} />
        <TextInput
          spellCheck={false}
          style={{backgroundColor: 'white', margin: 10}}
          accessibilityLabel="spellCheck"
        />        
        <TextInput
          grammarCheck={false}
          style={{backgroundColor: 'white', margin: 10}}
          accessibilityLabel="grammarCheck"
        />
        <TextInput
          autoCorrect={false}
          style={{backgroundColor: 'white', margin: 10}}
          accessibilityLabel="autoFocus"
        />
      </>
      );
    },
  },

Before

before.mov

After

after.mov

@christophpurrer christophpurrer requested a review from a team as a code owner July 25, 2022 23:24
Similar to microsoft#1292 this adds a macOS only property to toggle grammarCheck on RCTUITextField
@chiuam chiuam merged commit e9f8381 into microsoft:main Jul 27, 2022
christophpurrer pushed a commit to christophpurrer/react-native-macos that referenced this pull request Aug 10, 2022
# Conflicts:
#	Libraries/Components/TextInput/TextInput.js
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Feb 13, 2023
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Mar 10, 2023
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
Summary:
X-link: facebook/yoga#1293

Pull Request resolved: facebook#37384

Gets the project mostly clean of `-Wunused-parameter`, part of `-Wextra`.

Reviewed By: yungsters

Differential Revision: D45772554

fbshipit-source-id: 7c9f475de6f2568927d1c451e8de0dda89395f61
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
Summary:
X-link: facebook/yoga#1293

Pull Request resolved: facebook#37384

Gets the project mostly clean of `-Wunused-parameter`, part of `-Wextra`.

Reviewed By: yungsters

Differential Revision: D45772554

fbshipit-source-id: c5dbfbd6604caf3f7352c69d120a91e056185c85
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
Summary:
X-link: facebook/yoga#1293

Pull Request resolved: facebook#37384

Gets the project mostly clean of `-Wunused-parameter`, part of `-Wextra`.

Reviewed By: yungsters

Differential Revision: D45772554

fbshipit-source-id: b2b4bcf90129013141b151efc9c878c8eb91c3b0
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request May 11, 2023
Summary:
X-link: facebook/yoga#1293

Pull Request resolved: facebook#37384

Gets the project mostly clean of `-Wunused-parameter`, part of `-Wextra`.

Reviewed By: yungsters

Differential Revision: D45772554

fbshipit-source-id: fbb57752c2be50ad9c0ffe5627a6a67391ff6a83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants