Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.72][JSCRuntime] Add runtimeConfig to set debugger options #1959

Merged
merged 3 commits into from
Oct 28, 2023

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Oct 21, 2023

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary:

Cherry pick of facebook#38942 and facebook#39549 to React Native macOS. The upstream change hasn't landed yet, but we would like to use this change internally regardless.

Changelog:

[IOS] [CHANGED] - Add facebook::jsc::runtimeConfig to set enable debugger and set debugger

Test Plan:

Running RNTester with JSC shows the JSContext with the updated name.

@Saadnajmi Saadnajmi requested a review from a team as a code owner October 21, 2023 00:45
@Saadnajmi Saadnajmi force-pushed the names-macos-72 branch 3 times, most recently from 01473cc to c94ec2d Compare October 21, 2023 01:22
@Saadnajmi Saadnajmi merged commit f72bf86 into microsoft:0.72-stable Oct 28, 2023
15 checks passed
@Saadnajmi Saadnajmi deleted the names-macos-72 branch October 28, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants