[JSCRuntime] Add runtimeConfig to set debugger options

[Saadnajmi]

Summary:

When using React Native with JavascriptCore with a brownfield app, you may have multiple instances of React Native running, each with a JSContext. You attach a debugger to this JSContext via the Safari->Develop menu. To distinguish multiple JSContexts apart, JSContext has a name property, with a C style setter. We currently don't take advantage of that property, meaning that all your React Native instances show in the Develop menu with the default name "JSContext", making them hard to distinguish from each other.

Let's solve this by adding a runtimeConfig parameter to the method makeJSCRuntime(), and pass through the properties enableDebugger and debuggerName to it. These names / the API to set them are heavily inspired by a similar change made to HermesExecutorFactory: 32d12e8

Changelog:

[IOS] [CHANGED] - Add facebook::jsc::runtimeConfig to set enable debugger and set debugger

Test Plan:

Running RNTester with JSC shows the JSContext with the updated name.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	17,657,546	+23,343
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	21,039,214	+21,155
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: d2e8225
Branch: main

[motiz88]

Hey @Saadnajmi! I agree with the intent of this PR and would like to ship something close to this, but see some concerns/suggestions in comments.

[Saadnajmi]

Closing this PR till I rework it with the feedback above.
EDIT: which I did a couple of hours later 😅

[Saadnajmi]

@motiz88 friendly ping, in case you could take a second look

[motiz88]

So sorry about the delay, but I have some concerns here (plus some nits).

[Saadnajmi]

@motiz88 Could you take another look? I've addressed your new set of comments

[Saadnajmi]

Oversight caught internally: Initially this was always true so release builds would have the debugger enabled. I changed it so the default is true only for debug. This way, one could still enable debugging for a ship/release build if they wished.

I considered copying what Hermes does and putting all debugging code behind a custom preprocessor variable (#37723), but that seemed overkill and would prevent us from enable debugging on ship.
For reference, equivalent PRs in React Native macOS:
microsoft#1976
microsoft#1977
microsoft#1978
microsoft#1979

[github-actions]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This PR was closed because it has been stalled for 7 days with no activity.