Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSCRuntime] Only enable the JSC debugging in DEBUG by default #1976

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Nov 7, 2023

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary:

#1957 set the JSC debugging to always be true, even on Release builds. Let's ifdef the default so it's only true for debug. This way, we can continue to support allowing a user to enable debugging for release builds if they wish.

Changelog:

[GENERAL] [CHANGED] - Only enable JSC debugging in DEBUG by default

Test Plan:

CI should pass. I couldn't get a good ship build of RN, but this is a fairly simple change.

@Saadnajmi Saadnajmi merged commit 15ea449 into microsoft:main Nov 7, 2023
18 of 19 checks passed
@Saadnajmi Saadnajmi deleted the debug-ship branch November 8, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants