Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-native): runMacOS.js depends on chalk #1989

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 28, 2023

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary:

runMacOS.js uses chalk but relies on other dependencies also depending on it and specific hoisting mechanisms to access it. This fails in a pnpm setup.

Changelog:

[GENERAL] [FIXED] - runMacOS.js depends on chalk but doesn't declare it

Test Plan:

n/a

@tido64 tido64 requested a review from a team as a code owner November 28, 2023 09:02
@@ -19,10 +36,10 @@ const {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also depend on @react-native-community/cli-tools without declaring it in package.json. Do we want to add it as an explicit dependency or resolve it via @react-native-community/cli?

cc @acoates-ms

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tido64 tido64 merged commit e76c02f into main Nov 29, 2023
19 of 21 checks passed
@tido64 tido64 deleted the tido/fix-pnpm-issues branch November 29, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants