Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-native): runMacOS.js depends on @react-native-community/cli-tools #1993

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 30, 2023

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary:

runMacOS.js uses @react-native-community/cli-tools but relies on other dependencies also depending on it and specific hoisting mechanisms to access it. This fails in a pnpm setup.

Related: #1989

Changelog:

[GENERAL] [FIXED] - runMacOS.js depends on @react-native-community/cli-tools but doesn't declare it

Test Plan:

n/a

@tido64 tido64 merged commit 164469a into main Dec 6, 2023
20 of 24 checks passed
@tido64 tido64 deleted the tido/fix-cli-tools branch December 6, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants