[Fabric] Fix y-position of TextInput's caret #11717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Area: Fabric
acoates-ms
reviewed
Jun 8, 2023
vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp
Outdated
Show resolved
Hide resolved
acoates-ms
approved these changes
Jun 12, 2023
jonthysell
added
the
New Architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the y-position of TextInput's caret when located within a ScrollView. The ScrollViewComponent adds extra space via the getClientRect after TextInput gets initially drawn. This uses the correct RECT that is set when TextInput is drawn.
Type of Change
Why
Resolves #11486
Screenshots
Before
Playground-composition_ss18BwPvtd.mp4
After
Playground-composition_UsbX41QD6k.mp4
Testing
Tested locally
Microsoft Reviewers: Open in CodeFlow