feat(NativeAnimated): Adds support for animated events #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozele
commented
Nov 10, 2016
| { | ||
| this._uiImplementation = uiImplementation; | ||
| _uiImplementation = uiManager.UIImplementation; | ||
| uiManager.EventDispatcher.AddListener(this); |
There was a problem hiding this comment.
EventDispatcher [](start = 22, length = 15)
We may want to consider making this disposable / removable. #WontFix
This adds support for `Animated.event` driven natively. At the moment, it works by providing a mapping between a view tag, an event name, an event path and an animated value when a view has a prop with a `AnimatedEvent` object. Then we can hook into `EventDispatcher`, check for events that target our view + event name and update the animated value using the event path. For now it works with the onScroll event but it should be generic enough to work with anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
Animated.eventdriven natively.At the moment, it works by providing a mapping between a view tag, an event name, an event path and an animated value when a view has a prop with a
AnimatedEventobject. Then we can hook intoEventDispatcher, check for events that target our view + event name and update the animated value using the event path.For now it works with the onScroll event but it should be generic enough to work with anything.