-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NativeAnimated): Adds support for animated events #874
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
ReactWindows/ReactNative.Shared/UIManager/Events/IEventDispatcherListener.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
namespace ReactNative.UIManager.Events | ||
{ | ||
/// <summary> | ||
/// Interface used to intercept events dispatched by <see cref="EventDispatcher"/>. | ||
/// </summary> | ||
public interface IEventDispatcherListener | ||
{ | ||
/// <summary> | ||
/// Called on every time an event is dispatched using <see cref="EventDispatcher.DispatchEvent(Event)"/>. | ||
/// Will be called from the same thread that the event is being | ||
/// dispatched from. | ||
/// </summary> | ||
/// <param name="event">Event that was dispatched.</param> | ||
/// <returns> | ||
/// If the event was handled. If true the event won't be sent to | ||
/// JavaScript. | ||
/// </returns> | ||
bool OnEventDispatch(Event @event); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
using Newtonsoft.Json.Linq; | ||
using ReactNative.UIManager.Events; | ||
using System; | ||
using System.Collections.Generic; | ||
using static System.FormattableString; | ||
|
||
namespace ReactNative.Animated | ||
{ | ||
class EventAnimationDriver : RCTEventEmitter | ||
{ | ||
private readonly IList<string> _eventPath; | ||
|
||
public EventAnimationDriver(IList<string> eventPath, ValueAnimatedNode valueNode) | ||
{ | ||
_eventPath = eventPath; | ||
ValueNode = valueNode; | ||
} | ||
|
||
public ValueAnimatedNode ValueNode | ||
{ | ||
get; | ||
} | ||
|
||
public override void receiveEvent(int targetTag, string eventName, JObject @event) | ||
{ | ||
if (@event == null) | ||
{ | ||
throw new ArgumentNullException(nameof(@event), "Native animated events must have event data."); | ||
} | ||
|
||
// Get the new value for the node by looking into the event map using the provided event path. | ||
var current = @event; | ||
for (var i = 0; i < _eventPath.Count - 1; i++) | ||
{ | ||
current = (JObject)current[_eventPath[i]]; | ||
} | ||
|
||
ValueNode.Value = current.Value<double>(_eventPath[_eventPath.Count - 1]); | ||
} | ||
|
||
public override void receiveTouches(string eventName, JArray touches, JArray changedIndexes) | ||
{ | ||
throw new NotSupportedException( | ||
Invariant($"Method '{nameof(receiveTouches)}' is not support by native animated events.")); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to consider making this disposable / removable. #WontFix