-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebuilt provides debug builds #15
Comments
Good catch, we are supposed to run strip, but that changed in https://github.com/microsoft/ripgrep-prebuilt/pull/12/files#diff-76d4e149397662fc7816e58b93b9f29d24f27bc395874ca1e090ad6037477ea1R17. cc @deepak1556, I will just remove that condition, I don't think it's needed. |
Oh I see, so there is no |
@deepak1556 I can't find any way to strip the musl builds, do you have any idea? |
@roblourens You likely build ripgrep via sources, right? Are there any reasons to build a release version with debug information and strip it before packing? Otherwise you could set |
Thanks @fxha I'll try that |
We build from https://github.com/BurntSushi/ripgrep and the debug info is set in the release profile https://github.com/BurntSushi/ripgrep/blob/0b36942f680bfa9ae88a564f2636aa8286470073/Cargo.toml#L80, I don't think we can override it during build via cargo ? |
Of course you can overwrite repo configs with a cargo profile by creating a file named
Please see https://doc.rust-lang.org/cargo/reference/profiles.html for more details. |
@roblourens This problem seems solved, make a new release please? It saved size a lot in vscode package. |
We recently noticed that our build size suddenly increased after updating dependencies. The reasons for this is a 40MB ripgrep application with debug information on Linux (other OSs not tested). I hope you can fix this issue and provide a release version without debug information. Thanks in advance!
Edit: Target
x86_64-unknown-linux-musl
The text was updated successfully, but these errors were encountered: