Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release a new version of ripgrep-prebuilt, it saved ~33 MiB in vscode #174294

Closed
kkocdko opened this issue Feb 13, 2023 · 4 comments
Closed
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality search Search widget and operation issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@kkocdko
Copy link
Contributor

kkocdko commented Feb 13, 2023

The issue microsoft/ripgrep-prebuilt#15 reported this problem and it's fixed, but no versions released after that fix. So until now the ripgrep binary in vscode still so big:

[kkocdko@klf vscode-linux-x64]$ ls -lh ./node_modules/@vscode/ripgrep/bin/rg 
-rwxr-xr-x. 1 kkocdko kkocdko 38M Oct 27  2021 ./node_modules/@vscode/ripgrep/bin/rg
[kkocdko@klf vscode-linux-x64]$ strip ./node_modules/@vscode/ripgrep/bin/rg 
[kkocdko@klf vscode-linux-x64]$ ls -lh ./node_modules/@vscode/ripgrep/bin/rg 
-rwxr-xr-x. 1 kkocdko kkocdko 5.4M Feb 14 07:13 ./node_modules/@vscode/ripgrep/bin/rg
[kkocdko@klf vscode-linux-x64]$ 

Please, please release a new version of ripgrep-prebuilt and vscode-ripgrep.

@joaomoreno joaomoreno assigned roblourens and andreamah and unassigned joaomoreno Feb 17, 2023
@andreamah andreamah added this to the March 2023 milestone Feb 23, 2023
andreamah added a commit that referenced this issue Mar 13, 2023
andreamah added a commit that referenced this issue Mar 13, 2023
@andreamah
Copy link
Contributor

andreamah commented Mar 14, 2023

done in #177109

@andreamah andreamah added feature-request Request for new features or functionality author-verification-requested Issues potentially verifiable by issue author search Search widget and operation issues labels Mar 14, 2023
@andreamah
Copy link
Contributor

Hi @kkocdko! Can you verify that you see a smaller ripgrep executable in the insiders version? Thanks!

@andreamah andreamah added the verification-needed Verification of issue is requested label Mar 21, 2023
@connor4312 connor4312 added the verified Verification succeeded label Mar 21, 2023
@connor4312
Copy link
Member

$ du -h bin/*/rg
3.2M    bin/aarch64-apple-darwin/rg
3.9M    bin/aarch64-unknown-linux-musl/rg
3.5M    bin/arm-unknown-linux-gnueabihf/rg
3.8M    bin/i686-unknown-linux-musl/rg
4.3M    bin/powerpc64le-unknown-linux-gnu/rg
4.9M    bin/s390x-unknown-linux-gnu/rg
3.9M    bin/x86_64-apple-darwin/rg
4.9M    bin/x86_64-unknown-linux-musl/rg

@kkocdko
Copy link
Contributor Author

kkocdko commented Mar 30, 2023

ed this problem and it's fixed, but no versions released after that fix. So until now the ripgrep binary in vscode still so big:

[kkocdko@klf vscode-insider]$ ls -lh node_modules/@vscode/ripgrep/bin/
total 4.9M
-rwxr-xr-x. 1 kkocdko kkocdko 4.9M Mar 11 03:50 rg

It's fine now, thanks to every contributors!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality search Search widget and operation issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants