Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arm-unknown-linux-gnueabihf enforces a minimum GLIBC #24

Open
andreamah opened this issue Apr 5, 2023 · 2 comments · May be fixed by #29
Open

arm-unknown-linux-gnueabihf enforces a minimum GLIBC #24

andreamah opened this issue Apr 5, 2023 · 2 comments · May be fixed by #29
Assignees
@andreamah
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@andreamah
Copy link
Contributor

Related: microsoft/vscode#179121 (comment)

It seems like systems that use arm-unknown-linux-gnueabihf looks for GLIBC_2.29 despite vscode supporting lower GLIBC versions. This is since that prebuilt is still not statically compiled, so building it against ubuntu-latest likely increased the GLIBC version that it required from dynamically linked dependences.

We should try to make this prebuilt statically compiled by using the musl version, as we did with microsoft/vscode-ripgrep#34
@andreamah andreamah added the bug Issue identified by VS Code Team member as probable bug label Apr 5, 2023
@andreamah andreamah self-assigned this Apr 5, 2023
andreamah added a commit that referenced this issue Apr 5, 2023
@andreamah
change arm-unknown-linux-gnueabihf to musl
bc68756 
Fixes #24
@andreamah andreamah mentioned this issue Apr 5, 2023
Closed
@roblourens
Copy link
Member

If you have trouble with the real fix and you want to do a quick fix to get out in Insiders, maybe we can do something where we ship the old version of the binary just for this one arch, and the others continue using the latest.

@andreamah andreamah mentioned this issue Apr 6, 2023
Closed
@andreamah andreamah mentioned this issue May 3, 2023
Closed
@deepak1556
Copy link
Contributor

If you find there are perf costs to using musl, you can instead build on container targets that aligns the minimum GLIBC with VSCode server.

For armhf - we build on Debian buster https://github.com/microsoft/vscode-linux-build-agent/blob/main/buster-armhf/Dockerfile
For arm64 - we build on Centos7 Devtoolset8 https://github.com/microsoft/vscode-linux-build-agent/blob/main/centos7-devtoolset8-arm64/Dockerfile

@andreamah andreamah mentioned this issue May 24, 2023
Closed
@andreamah andreamah linked a pull request Jun 7, 2023 that will close this issue
Draft
@Sachin-Itagi Sachin-Itagi mentioned this issue Nov 1, 2023
Closed
@andreamah andreamah mentioned this issue Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreamah andreamah

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
3 participants
@roblourens @deepak1556 @andreamah