[heft-jest-plugin, repo] Fix issues with punycode in jest-environment-jsdom and add Node 22 to the repo test matrix.
#5038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
patmill
as code owners
iclanton
force-pushed
the
heft-jest-punycode
branch
2 times, most recently
from
3f944ec to
605e733
Compare
iclanton
force-pushed
the
heft-jest-punycode
branch
from
605e733 to
7633c0f
Compare
D4N14L
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Importing
punycodeemits a deprecating warning starting in Node 22 andjsdomimportspunycode. This PR introduces a patch that injectspunycodeinto the NodeJS require cache before loadingjest-environment-jsdom.This PR also adds Node 22 to the test matrix.
Fixes #5033 and #5008
How it was tested
Built and ran unit tests.
Note that thenode-core-librarytests are failing in Node 22 on Windows and need to be investigated.Impacted documentation
The
punycodeinjection should be documented.