Added initialPosition and launchMode to settings schema (#4222)

* added initialPosition and launchMode to schema * regex works * fixed regex bug * remove lookaround * Update doc/cascadia/profiles.schema.json Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com> * update description in settingsschema.md * edit descriptions to have code markings * remove code backticks from schema Co-authored-by: Dustin L. Howett (MSFT) <duhowett@microsoft.com>
microsoft · Jan 28, 2020 · 814f4ca · 814f4ca
1 parent 8c46e74
commit 814f4ca
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/doc/cascadia/SettingsSchema.md b/doc/cascadia/SettingsSchema.md
@@ -9,7 +9,9 @@ Properties listed below affect the entire window, regardless of the profile sett
 | `copyOnSelect` | Optional | Boolean | `false` | When set to `true`, a selection is immediately copied to your clipboard upon creation. When set to `false`, the selection persists and awaits further action. |
 | `defaultProfile` | _Required_ | String | PowerShell guid | Sets the default profile. Opens by typing <kbd>Ctrl</kbd> + <kbd>T</kbd> or by clicking the '+' icon. The guid of the desired default profile is used as the value. |
 | `initialCols` | _Required_ | Integer | `120` | The number of columns displayed in the window upon first load. |
+| `initialPosition` | Optional | String | `","` | The position of the top left corner of the window upon first load. On a system with multiple displays, these coordinates are relative to the top left of the primary display. If `launchMode` is set to `"maximized"`, the window will be maximized on the monitor specified by those coordinates. |
 | `initialRows` | _Required_ | Integer | `30` | The number of rows displayed in the window upon first load. |
+| `launchMode` | Optional | String | `default` | Defines whether the Terminal will launch as maximized or not. Possible values: `"default"`, `"maximized"` |
 | `rowsToScroll` | Optional | Integer | `system` | The number of rows to scroll at a time with the mouse wheel. This will override the system setting if the value is not zero or "system". |
 | `requestedTheme` | _Required_ | String | `system` | Sets the theme of the application. Possible values: `"light"`, `"dark"`, `"system"` |
 | `showTerminalTitleInTitlebar` | _Required_ | Boolean | `true` | When set to `true`, titlebar displays the title of the selected tab. When set to `false`, titlebar displays "Windows Terminal". |

diff --git a/doc/cascadia/profiles.schema.json b/doc/cascadia/profiles.schema.json
@@ -9,6 +9,10 @@
       "type": "string",
       "format": "color"
     },
+    "Coordinates": {
+      "pattern": "^(-?\\d+)?(,\\s?(-?\\d+)?)?$",
+      "type": "string"
+    },
     "ProfileGuid": {
       "default": "{}",
       "pattern": "^\\{[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}\\}$",
@@ -279,13 +283,26 @@
           "minimum": 1,
           "type": "integer"
         },
+        "initialPosition": {
+          "$ref": "#/definitions/Coordinates",
+          "description": "The position of the top left corner of the window upon first load. On a system with multiple displays, these coordinates are relative to the top left of the primary display. If launchMode is set to maximized, the window will be maximized on the monitor specified by those coordinates."
+        },
         "initialRows": {
           "default": 30,
           "description": "The number of rows displayed in the window upon first load.",
           "maximum": 999,
           "minimum": 1,
           "type": "integer"
         },
+        "launchMode": {
+          "default": "default",
+          "description": "Defines whether the Terminal will launch as maximized or not.",
+          "enum": [
+            "maximized",
+            "default"
+          ],
+          "type": "string"
+        },
         "rowsToScroll": {
           "default": "system",
           "description": "The number of rows to scroll at a time with the mouse wheel. This will override the system setting if the value is not zero or 'system'.",
@@ -322,7 +339,7 @@
         },
         "snapToGridOnResize": {
           "default": false,
-          "description": "When set to `true`, the window will snap to the nearest character boundary on resize. When `false`, the window will resize 'smoothly'",
+          "description": "When set to true, the window will snap to the nearest character boundary on resize. When false, the window will resize 'smoothly'",
           "type": "boolean"
         },
         "tabWidthMode": {
@@ -609,7 +626,7 @@
           "type": "string"
         },
         "suppressApplicationTitle": {
-          "description": "When set to `true`, `tabTitle` overrides the default title of the tab and any title change messages from the application will be suppressed. When set to `false`, `tabTitle` behaves as normal.",
+          "description": "When set to true, tabTitle overrides the default title of the tab and any title change messages from the application will be suppressed. When set to false, tabTitle behaves as normal.",
           "type": "boolean"
         },
         "tabTitle": {