Added initialPosition and launchMode to settings schema

[cinnamon-msft]

Summary of the Pull Request

Added initialPosition and launchMode to settings json schema and md file

References

PR Checklist

• Closes Settings Schema is Missing Initial Position and Launch Mode #3290
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Requires documentation to be updated
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

[cinnamon-msft]

I know the regex for the coordinates is wrong, currently working to figure it out.

[modscleo4]

Try using ^(\d+),[ ]?(\d+)$ for Launch position, I think it's better

[DHowett-MSFT]

Hold up, don't do that. Lookarounds are expensive.

The correct way to fix this is -- assuming you want to support 5 5,5 and ,5 -- to include the , inside one of the optional groups.

Use this pattern.

^(-?\\d+)?(,?\\s?-?\\d+)?$

Including the , in the second optional group (also: \s matches a single space, and is valuable to put in places users might put spaces) means you don't need to have an expensive negative lookaround in the regex that says "plx make sure it doesn't contain 5-5"

[DHowett-MSFT]

Using ? for \s makes it so that they can only say 5, 5 or 5,5 -- they can't say 5,<space space space space space>5. (edit: github ate the spaces)

Unfortunately, they can say 5,\n5 😁

[cinnamon-msft]

We also have to allow for 5, 😟

[DHowett-MSFT]

Yes, that is part of the thing I said ;P

[DHowett-MSFT]

actually, I'd go so far as to replace the ,? with , -- because the entire second part is optional already..

^(-?\\d+)?(,\\s?-?\\d+)?$ -- to be valid, the second part must have a ,. you cannot say 5 5.

[cinnamon-msft]

Wait, the pattern you have doesn't allow for 5,

Also, having "" will just use the default settings, so that's probably fine?

[DHowett-MSFT]

ah, 5, is legal.

^(-?\\d+)?(,\\s?(-?\\d+)?)?$

[DHowett-MSFT]

"if there's a second digit group it must be preceded by ,\s+ but there doesn't need to be digits after the ,"

[DHowett-MSFT]

[cinnamon-msft]

Ah okay yeah that works :) I'll add it in! Thanks 😄

[cinnamon-msft]

Ah nope, I'll remove them now. They're in other places throughout the schema so I'll take them all out.