Skip to content

Commit

Permalink
Fix slowdown on open/close tabs when the user has many profiles (#7993)
Browse files Browse the repository at this point in the history
## Summary of the Pull Request
Just deleting an unnecessary call to `_UpdateCommandsForPalette`

**Note:** This only fixes slowdown when opening/closing a tab, but not upon first startup (we still need to call `_UpdateCommandsForPalette` there

## References
Fixes the slowdown described in #7820 for opening and closing tabs, but doesn't improve startup time dramatically.

## Validation Steps Performed
Tested with ~100 profiles in my settings file

(cherry picked from commit 895ac06)
  • Loading branch information
PankajBhojwani authored and DHowett committed Oct 27, 2020
1 parent 888b6e9 commit a0a70cc
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/cascadia/TerminalApp/TerminalPage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1926,10 +1926,6 @@ namespace winrt::TerminalApp::implementation
_rearrangeTo = eventArgs.Index();
}
}
else
{
_UpdateCommandsForPalette();
}

_UpdateTabView();
}
Expand Down

0 comments on commit a0a70cc

Please sign in to comment.