Fix slowdown on open/close tabs when the user has many profiles #7993
Conversation
ghost
added
Area-Performance
|
@PankajBhojwani - will the command palette be still updated if I have it open in the tab-switch mode and create a new tab? I guess the answer is yes, but just checking. |
@Don-Vito Yep, this function call was actually entirely a vestigial remnant from an earlier prototype. The tab switcher mode for the command palette uses a totally different mechanism for populating the list of tabs. |
|
I'd suggest that you remove the We need to figure our how to improve startup time. |
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 5 hours 22 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot merge this in 4 minutes |
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit
|
@zadjii-msft , @PankajBhojwani - this did regressed. Once if you had the command palette open on the tab switcher and you were added the new tab it was added to the list of the commands immediately. Now it will will be updated only on the next opening of the tab switcher. |
|
@DHowett - it is certainly is. I already verified it (while merging main to #7977). Sorry @PankajBhojwani 😄 |
|
So, generally we consider the switcher to be “ephemeral”; it shouldn’t be onscreen while tabs are changing, but it shouldn’t be dangerous if it is. So long as it doesn’t crash, i’m okay with an n-1 state snapshot being on display. |
@DHowett - in "command palette highlighting" I worked really hard to change the highlighted text if the command name is changed in the background (e.g. when new tab is open). Can I remove it? |
## Summary of the Pull Request Just deleting an unnecessary call to `_UpdateCommandsForPalette` **Note:** This only fixes slowdown when opening/closing a tab, but not upon first startup (we still need to call `_UpdateCommandsForPalette` there ## References Fixes the slowdown described in #7820 for opening and closing tabs, but doesn't improve startup time dramatically. ## Validation Steps Performed Tested with ~100 profiles in my settings file (cherry picked from commit 895ac06)
|
🎉 Handy links: |
|
🎉 Handy links: |
Summary of the Pull Request
Just deleting an unnecessary call to
_UpdateCommandsForPaletteNote: This only fixes slowdown when opening/closing a tab, but not upon first startup (we still need to call
_UpdateCommandsForPalettethereReferences
Fixes the slowdown described in #7820 for opening and closing tabs, but doesn't improve startup time dramatically.
Validation Steps Performed
Tested with ~100 profiles in my settings file