Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce read-only actions page and use it in Stable builds (til::feature) #10578

Closed
DHowett opened this issue Jul 7, 2021 · 0 comments · Fixed by #10581
Closed

Reintroduce read-only actions page and use it in Stable builds (til::feature) #10578

DHowett opened this issue Jul 7, 2021 · 0 comments · Fixed by #10581
Assignees
@carlos-zamora
Labels
Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.10

Comments

@DHowett
Copy link
Member

DHowett commented Jul 7, 2021 •
edited
Loading

We've decided that the action editing experience is not suitable for broad release to the stable channel yet -- we'll need to resurrect the read-only action list in 1.9 and 1.10.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 7, 2021
@DHowett DHowett added Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Jul 7, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 7, 2021
@DHowett DHowett added this to the Terminal v1.10 milestone Jul 7, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 7, 2021
@carlos-zamora carlos-zamora mentioned this issue Jul 7, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Jul 7, 2021
@ghost ghost closed this as completed in #10581 Jul 8, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 8, 2021
ghost pushed a commit that referenced this issue Jul 8, 2021
@carlos-zamora
Introduce feature flag for editable actions page (#10581)
f03cacf 
## Summary of the Pull Request
Adds a feature flag `Feature_EditableActionsPage` that controls whether the Actions page in the Settings UI is read-only vs editable. The editable version is disabled for `Release` builds and enabled everywhere else (i.e. Dev, Preview, etc...).

Validated using `<stage>` `AlwaysEnabled` and `AlwaysDisabled`.

## References
#6900 - Actions Page Epic

## PR Checklist
Closes #10578
DHowett pushed a commit that referenced this issue Jul 12, 2021
@carlos-zamora @DHowett
Introduce feature flag for editable actions page (#10581)
89b420c 
Adds a feature flag `Feature_EditableActionsPage` that controls whether the Actions page in the Settings UI is read-only vs editable. The editable version is disabled for `Release` builds and enabled everywhere else (i.e. Dev, Preview, etc...).

Validated using `<stage>` `AlwaysEnabled` and `AlwaysDisabled`.

Closes #10578

(cherry picked from commit f03cacf)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.10
Development

Successfully merging a pull request may close this issue.

Introduce feature flag for editable actions page microsoft/terminal
2 participants
@DHowett @carlos-zamora