Introduce feature flag for editable actions page

[carlos-zamora]

Summary of the Pull Request

Adds a feature flag Feature_EditableActionsPage that controls whether the Actions page in the Settings UI is read-only vs editable. The editable version is disabled for Release builds and enabled everywhere else (i.e. Dev, Preview, etc...).

Validated using <stage> AlwaysEnabled and AlwaysDisabled.

References

#6900 - Actions Page Epic

PR Checklist

Closes #10578

[carlos-zamora]

This is a draft because I can't actually deploy Windows Terminal for some reason. I'm getting some kind of deployment error. I think the implementation is correct, but alas, this is all unverified.

[DHowett]

Thanks for doing this! Couple notes

• this should apply to 1.10 as well; we should do the work on main and backport it. Feature flags let us not have one-off changes per branch :)
• should we actually just resurrect the 1.8 code as a completely separate XAML page and code-behind file for this? It will let us change the 1.9 and 1.10 ones without merge conflicts and without risking breaking the feature by accidentally leaking part of it to stable

[WSLUser]

So does this mean the preview versions also won't have editable actions? It seems the focus is stable not having this option but also mentioned 1.10 as well...I'd prefer the preview still have this feature for testing.

[DHowett]

So does this mean the preview versions also won't have editable actions? It seems the focus is stable not having this option but also mentioned 1.10 as well...I'd prefer the preview still have this feature for testing.

Opposite. Preview will have it, stable will not.

[zadjii-msft]

should we actually just resurrect the 1.8 code as a completely separate XAML page and code-behind file for this? It will let us change the 1.9 and 1.10 ones without merge conflicts and without risking breaking the feature by accidentally leaking part of it to stable

i really like that idea

[carlos-zamora]

Validated that this works when the feature flag is "on" vs "off" using AlwaysEnabled and AlwaysDisabled in stage. Looks great!

[carlos-zamora]

@msftbot merge this in 5 minutes

[ghost]

Hello @carlos-zamora!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I won't merge this pull request until after the UTC date Thu, 08 Jul 2021 20:55:04 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".