Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changed tab colors so I can no longer figure out which one is active 🤬 #12398

Closed
Tracked by #12400
mailinglists35 opened this issue Feb 6, 2022 · 4 comments · Fixed by #12529
Closed
Tracked by #12400

Update changed tab colors so I can no longer figure out which one is active 🤬 #12398

mailinglists35 opened this issue Feb 6, 2022 · 4 comments · Fixed by #12529
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes.
Milestone
Terminal v1.14

Comments

@mailinglists35
Copy link

Windows Terminal version

1.13.10336.0

Windows build number

10.0.19044.1466

Other Software

No response

Steps to reproduce

use terminal

wake up the next day

running terminal instance is gone from taskbar

open it again

open multiple tabs

Expected Behavior

able to figure out easily and quickly which tab is active

Actual Behavior

I can't figure out which tab is active, the colors of active and other tabs are messed by design of this update 🤬
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 6, 2022
@fitojb
Copy link

fitojb commented Feb 7, 2022

And how is that related to the Windows TERMINAL team? Please keep your insults to yourself, especially when they are totally misdirected.

@DHowett
Copy link
Member

DHowett commented Feb 7, 2022

@mailinglists35 this is your first and final warning. Cut it out.

@microsoft microsoft deleted a comment from mailinglists35 Feb 7, 2022
@microsoft microsoft deleted a comment from mailinglists35 Feb 7, 2022
@microsoft microsoft deleted a comment from mailinglists35 Feb 7, 2022
This was referenced Feb 7, 2022
Open
Open
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Feb 7, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 7, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.14 milestone Feb 7, 2022
@zadjii-msft zadjii-msft added Needs-Tag-Fix Doesn't match tag requirements zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. labels Feb 7, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 7, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 8, 2022
zadjii-msft added a commit that referenced this issue Feb 18, 2022
@zadjii-msft
Update light theme tab background for greater contrast.
71aa17d 
Changes the tab view BG to `#e8e8e8`, as discussed in mail thread.

Closes #12398
@zadjii-msft zadjii-msft mentioned this issue Feb 18, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Feb 18, 2022
@ghost ghost closed this as completed in #12529 Feb 24, 2022
ghost pushed a commit that referenced this issue Feb 24, 2022
@zadjii-msft
Update light theme tab background for greater contrast. (#12529)
c62705e 
Changes the tab view BG to `#e8e8e8`, as discussed in mail thread.

Closes #12398
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 24, 2022
@rgwood
Copy link

rgwood commented Feb 25, 2022 •
edited
Loading

@zadjii-msft Thank you for fixing this in light mode! I think it also needs a fix in dark mode.

Dark mode before the WinUI change:

image

Dark mode now:

image

I now find it nearly impossible to tell which tab is active at a glance.

zadjii-msft added a commit that referenced this issue Mar 3, 2022
@zadjii-msft
Update light theme tab background for greater contrast. (#12529)
cf26d27 
Changes the tab view BG to `#e8e8e8`, as discussed in mail thread.

Closes #12398
zadjii-msft added a commit that referenced this issue Mar 7, 2022
@zadjii-msft
Update the tab colors some more
b1e3c79 
Again, to reflect continuing discussion with the WinUI team. A doc may have been misread - these are the colors they're proposing, which are generally a lot better.

See also: #12400, #12356, #12398
@zadjii-msft zadjii-msft mentioned this issue Mar 7, 2022
Merged
ghost pushed a commit that referenced this issue Mar 9, 2022
@zadjii-msft
Update the tab colors some more (#12635)
aaa3ee7 
Again, to reflect continuing discussion with the WinUI team. A doc may have been misread - these are the colors they're proposing, which are generally a lot better.

See also: #12400, #12356, #12398

![image](https://user-images.githubusercontent.com/18356694/157041174-c0eb2140-3b49-4494-8746-b3a12f396fe6.png)
DHowett pushed a commit that referenced this issue Mar 10, 2022
@zadjii-msft @DHowett
Update light theme tab background for greater contrast. (#12529)
4f2bce1 
Changes the tab view BG to `#e8e8e8`, as discussed in mail thread.

Closes #12398

(cherry picked from commit c62705e)
DHowett pushed a commit that referenced this issue Mar 10, 2022
@zadjii-msft @DHowett
Update the tab colors some more (#12635)
1388b59 
Again, to reflect continuing discussion with the WinUI team. A doc may have been misread - these are the colors they're proposing, which are generally a lot better.

See also: #12400, #12356, #12398

![image](https://user-images.githubusercontent.com/18356694/157041174-c0eb2140-3b49-4494-8746-b3a12f396fe6.png)

(cherry picked from commit aaa3ee7)
zadjii-msft added a commit that referenced this issue Mar 10, 2022
@zadjii-msft
Update the tab colors some more (#12635)
e967fd4 
Again, to reflect continuing discussion with the WinUI team. A doc may have been misread - these are the colors they're proposing, which are generally a lot better.

See also: #12400, #12356, #12398

![image](https://user-images.githubusercontent.com/18356694/157041174-c0eb2140-3b49-4494-8746-b3a12f396fe6.png)
@ghost
Copy link

ghost commented Mar 25, 2022

🎉This issue was addressed in #12529, which has now been successfully released as Windows Terminal Preview v1.13.1073.:tada:

Handy links:

@zadjii-msft zadjii-msft mentioned this issue Apr 20, 2022
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes.
Projects
None yet
Milestone
Terminal v1.14
Development

Successfully merging a pull request may close this issue.

Update light theme tab background for greater contrast. microsoft/terminal
5 participants
@DHowett @fitojb @mailinglists35 @zadjii-msft @rgwood