Bring back the old titlebar color #12939
Comments
Mystic8b
added
the
Issue-Feature
ghost
added
Needs-Tag-Fix
|
Try enabling "show acrylic in tab row", it looks less bad. Though it that mode the active and inactive tab are very hard to distinguish. I personally preferred the old titlebar colour too, though I think most of the ugliness I've noticed is from #11561. |
Acrylic enabled. Previously, I achieved the same color for the titlebar and the terminal window, and in focus the entire window was transparent in the same color, and without focus, it was gray, but also without an explicit separation of titlebar and terminal. Now, in focus, I have a different shade of acrylic on the titlebar and the terminal itself, and without focus - that's horror. The first thing I will do in the office the day after tomorrow is to roll back the terminal to the old version. I have no idea how this was missed in the release. Also, now the titlebar appears before the terminal itself appears when opened. I have so many questions... |
|
I agree. I don't know if it is the same issue, but now the active tab is not with the same color of the background. In the following example I think that the active tab is the first, but actually it is the second tab. It is confusing.
I think it wasn't like that before. Please bring back the previous approach (or make it optional). EDIT:Yes, it has changed, the previous approach is still in the documentation (dark active tab). I think it was better. To solve my "problem", I had to change the default terminal color to the same as the active tab (RGB = 40,40,40). In the following figure, now it is clear to me that the active tab is the second. It is very more intuitive. Please make it default (in black option)
|
zadjii-msft
added
the
Needs-Discussion
zadjii-msft
added
Product-Terminal
|
I agree with all the issues raised here, and would add that the black background on the tab bar is visually confusing because it bleeds into and is all but indistinguishable from the contents of the window (assuming your console background is black, which it is by default). From a usability standpoint, this is troubling since it's not immediately clear where you're clicking on the titlebar to drag the window, and where you're simply clicking inside the terminal. The ideal solution in my view is to allow user customization of the tab and tab bar background colors, but assuming that's not a trivial addition, at a minimum the black tab bar background should be changed to a shade of gray that's easy to distinguish at a glance from the black console background. The previous color scheme of black active tab + gray inactive tabs and gray tab bar background was perfectly intuitive, as @Diogo-Rossi demonstrates (and a simple reversion would be fine by me). Thanks for your work on Terminal, it's really been improving by leaps and bounds. |
The problem is not in this, but in the fact that when the window is not in focus - completely black color looks catastrophically miserable. I sincerely do not understand why they did this, before the terminal was just perfect, now I can't look at it. |
|
With the new visual design, the tab needs to have that specific color, and the titlebar needs to be darker.
|
|
@dansmor7 my point is that the color of the active tab and the color of the terminal should match, so I can see what tab is active. This is the approach of tabs in Edge and Chrome browsers, look: In this example in Chrome, I can say the active bar is the second.
In this example in Edge, I can say the active bar is the third.
To make it clear: I got a screen shot from the documentation using the previous color.
|
|
Thanks for all the feedback here folks. You've definitely been heard loud and clear - the new colors aren't great. We tried to better align to the new Windows 11 visual styles, but without Mica it all looks a bit like a mess. We've been meaning for some time now to let folks customize the colors of the titlebar and the tabs. We've got a lot of stuff planned here - including the potential to match the tab or titlebar to the terminal BG color automatically. I think this discussion has finally given us the kick in our pants to finally do that. I'm gonna finish whipping up some prototypes for #3327 while we work on merging the spec over in #12530. As it stands - I don't think we're gonna change the defaults any time soon. We're just gonna give you a LOT more levers to let you do exactly what you want |
zadjii-msft
removed
the
Needs-Triage
|
Dear Windows Terminal team, you are doing a great job and I personally appreciate it a lot as current Windows Terminal is the best multi-tab terminal application I've seen for the last 20 years. And I know there were a lot of discussions already, but I still wish to emphasize the importance of the matter to a mainstream developer. The first thing, that "feels" wrong is changing the coloring logic to the exact opposite of what is was before. Here are two examples: old and new.
Both screenshots have second tab highlighted, yet in fact, old example has the first tab as active and the new example has the second tab as active. This change obviously confuses people who use the Terminal for some time. And I believe most of new users would also loose a "guess an active tab" game. The second and the most important point is that changes are ok as soon as they lead to better experience and/or are aligned with the best UI/UX practices. Yet with this change I believe the case is opposite. As Diogo-Rossi rightly noted, most modern apps utilize approach of having highlighted tab color matched with tab's background. And the change did the opposite of that. Again, as mentioned earlier, Edge, Chrome, VS Code, previous coloring of the Terminal, and even GitHub's comment widget are good examples of how tabs coloring could work decently and be something no one would complain about. I really hope you'll take our concerns into consideration and make some adjustments in the upcoming releases. Thanks. |
|
@Kolobamanacas Yep, we're definitely working on that. I've got the prototype over in |
zadjii-msft
removed
the
Needs-Discussion
#####⚠️ targeting 1.15 ## Summary of the Pull Request Adds support for Themes, a new type of customization for the Terminal. Themes allow the user to customize elements of the Terminal window itself. In this first iteration, this PR adds support for two main properties: * enabling Mica as the window backdrop * changing the tab row color (read: changing the titelbar color) These represent the most important asks of theming in the Terminal. The properties added in this PR are: * Theme color variants: - `"#rrggbb"` or `"#aarrggbb"` - `"accent"` - `"terminalBackground"` * Properties (_listed here in dot notation, but implemented as sub-objects_) - `tabRow.background`: accepts a ThemeColor (above) - `window.applicationTheme`: accepts one of `{"system", "light", "dark"}` - `window.useMica`: accepts a boolean, defaults to false. ## References * As first described in #3327 * spec'd in #12530 ## PR Checklist * [x] Sorta enables #10509, but doesn't close it. That'll need more comprehensive changes to the titlebar code. * **update**: I totally disabled mica, but left the serialization code. It just seems silly without #10509. * [x] Closes #1963 * [x] Closes #3774 * [x] Closes #12939 * [x] Does the bulk of the #3327 work, but I'm going to leave that open since that's become my megathread for everything related to theming. * [x] I work here * [x] Tests added/passed * [ ] Requires documentation to be updated - **SURE DOES** ## Detailed Description of the Pull Request / Additional comments ### --> GO READ #12530 <-- Seriously. These themes aren't customizable in the SUI currently. You can change the active theme, and the UI will show all of the defined themes, but they're not editable there. They don't layer. You'll need to define your own themes. Thay can't come from fragments. This is a really cool future idea, but not implemented in this v0. The sub objects have some gnarly macros to generate a lot of the serialization code for you. ### TODOs * [x] I still have yet to establish what the accent color algorithm is. This might be proprietary and require a ThemeHelpers workaround. * [x] Make sure `terminalBackground` & the SUI result in something sensible * [x] Make sure runtime BG changes work with `terminalBackground`. One time, they didn't. `printf "\x1b]11;rgb:ff/00/ff\x07"` * [x] Acrylic Terminal BG's look weird, like, the opacity is always 50% or something. And the tab row looks all wrong then. ## Validation Steps Performed This is the blob I've been testing with: <details> ```jsonc // "useAcrylicInTabRow": true, "theme": "my dark", // "theme": "Edge", "theme": "orangey", "theme": "WHITE", // "theme": "terminal", "themes": [ { "name": "my dark", "window": { "applicationTheme": "dark", "useMica": true, }, "tabRow": { "background": "#00000000", }, }, { "name": "Edge", "tabRow": { "background": "accent" }, "window": { "applicationTheme": "system" } }, { "name": "orangey", "window": { "applicationTheme": "light", "useMica": true, }, "tabRow": { "background": "#ff8800", }, }, { "name": "WHITE", "window": { "applicationTheme": "dark", "useMica": true, }, "tabRow": { "background": "#FFFFFF", }, }, { "name": "terminal", "window": { "applicationTheme": "dark", "useMica": false, }, "tabRow": { "background": "terminalBackground", }, }, ] ``` </details>
ghost
added
Resolution-Fix-Committed
|
🎉This issue was addressed in #12992, which has now been successfully released as Handy links: |
Description of the new feature/enhancement
The black titlebar looks incredibly bad. I literally can't believe you did this, maybe it's a bug. It is catastrophically bad without focus. I can't watch it. So much so that I'm willing to reinstall the terminal to the previous release every time after an automatic update.
Proposed technical implementation details (optional)
Please friends
The text was updated successfully, but these errors were encountered: