Windows Terminal not 100% shown in context menu

[lychichem]

Windows Terminal version

1.14.1861.0

Windows build number

10.0.22622.290

Other Software

No response

Steps to reproduce

1. Install windows terminal 1.14.1861.0
2. Right click in some folder
3. The bug happens.

Expected Behavior

The "open in terminal" should display every time.

Actual Behavior

The "open in terminal" don't display every time. I can see it 1 time when I right click every around 6 times.

[lychichem]

Maybe related to powertoys as it happens just after powertoys updated to 0.60.x

[zadjii-msft]

Hmm, that sure is weird. Can you file feedback using the Feedback Hub, under the "Desktop Environment > Right Click Context Menu" area/?

I'm not sure there's much we can do to investigate here, but getting this to the team that owns the context menus might help the investigation. If you "Share" the aka.ms link to that feedback here, I can make sure to follow the internal bug that gets generated. Thanks!

[lychichem]

Now I uninstalled powertoys, things looks ok. Will test again by reinstall powertoys.
Edit: confirmed this related to powertoys 0.60.x. Submitted to windows feedback with same title and content. And I guess it relates to this highlight:

[Skywings96]

I am very sure this problem is related to the latest version powertoys. If you want to fix it, you just need turn off Power Rename and Image Resizer.

[lychichem]

I am very sure this problem is related to the latest version powertoys. If you want to fix it, you just need turn off Power Rename and Image Resizer.

2 of 3 reasons I use powertoys are power rename and image resizer. So your fix seems painful for me...

[zadjii-msft]

I'm gonna tentatively say that this is tracking upstream. If this comes back as not a PowerToys AND not an OS issue, then we can reopen if there's something for us to fix here. Thanks for following up!

microsoft/PowerToys#19473

[zadjii-msft]

I'm actually gonna reopen this. We've got like, a LOT of crashes in OpenTerminalHere::GetState

There's no internal bug for this yet (weird), but it is in 33573326-3f07-2517-b549-6f77533ee596.

terminal/src/cascadia/ShellExtension/OpenTerminalHere.cpp

Lines 100 to 129 in 4e5a0c1

	HRESULT OpenTerminalHere::GetState(IShellItemArray* psiItemArray,
	BOOL /*fOkToBeSlow*/,
	EXPCMDSTATE* pCmdState)
	{
	// compute the visibility of the verb here, respect "fOkToBeSlow" if this is
	// slow (does IO for example) when called with fOkToBeSlow == FALSE return
	// E_PENDING and this object will be called back on a background thread with
	// fOkToBeSlow == TRUE
	// We however don't need to bother with any of that.
	// If no item was selected when the context menu was opened and Explorer
	// is not at a valid path (e.g. This PC or Quick Access), we should hide
	// the verb from the context menu.
	if (psiItemArray == nullptr)
	{
	const auto path = this->_GetPathFromExplorer();
	*pCmdState = path.empty() ? ECS_HIDDEN : ECS_ENABLED;
	}
	else
	{
	winrt::com_ptr<IShellItem> psi;
	psiItemArray->GetItemAt(0, psi.put());
	SFGAOF attributes;
	const bool isFileSystemItem = (psi->GetAttributes(SFGAO_FILESYSTEM, &attributes) == S_OK);
	*pCmdState = isFileSystemItem ? ECS_ENABLED : ECS_HIDDEN;
	}
	return S_OK;
	}

Maybe there's a way for the array to be non-null but have 0 items in it?

[zadjii-msft]

Promoted to MSFT:40872815

probably regressed in #13206

[zadjii-msft]

I'm pretty sure that we fixed this in https://github.com/microsoft/terminal/releases/tag/v1.15.2282.0 by reverting #13206. Thanks all!